Skip to content

Commit 96c45ca

Browse files
committed
Fix version number comparison in update checker.
1 parent 5439227 commit 96c45ca

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

codepulse/src/main/resources/toserve/common/UpdateController.js

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,16 @@
6363

6464
/** returns true if `releaseVersion` is newer than `ourVersion` */
6565
function compareVersions(ourVersion, releaseVersion) {
66-
var ourParts = ourVersion.split('.'), currentParts = releaseVersion.split('.')
67-
for (var i = 0, l = Math.max(ourParts.length, currentParts.length); i < l; i++) {
68-
var our = ourParts[i], current = currentParts[i]
69-
if (!our || our < current) return true
66+
// strip off any suffix (like -RC1)
67+
var ourParts = ourVersion.split('-')[0].split('.'), releaseParts = releaseVersion.split('-')[0].split('.')
68+
for (var i = 0, l = Math.max(ourParts.length, releaseParts.length); i < l; i++) {
69+
var our = parseInt(ourParts[i]) || 0,
70+
current = parseInt(releaseParts[i]) || 0
71+
72+
if (our < current) return true
73+
else if (our > current) break
7074
}
75+
7176
return false
7277
}
7378

0 commit comments

Comments
 (0)