Remove the collapse animation for the package list's initial appearance.

For large datasets, the initialization time was through the roof (90+
seconds for a package list with around 1500 items in it). I think the
problem was that the PackageWidgets were going through animations while
also trying to measure things (slideUp/Down to collapse/expand all at
once, and trying to measure the width of the barchart bars for label
positioning). I added an 'animate' parameter to the 'collapseChildren'
method, and use false for the initial collapse of all of the widgets. I
also removed the 'animating' property, since nothing was using it, and
it looked relatively expensive to calculate. Now the 90 second load time
is more like 5 seconds (for the dataset I was testing with, Jenkins)

Author: dylemma

codepulse/src/main/resources/toserve/pages/traces/PackageController.js

@@ -26,9 +26,6 @@
 		// build this into a Map[packageId -> packageWidget.selectedProp]
 		var stateTemplate = {}
 
-		// build this into a Map[packageId -> packageWidget.collapsingProp]
-		var collapsingTemplate = {}
-
 		var widgets = {}
 
 		// initialize the `stateTemplate` and `widgets` maps
@@ -39,17 +36,15 @@
 				var pw = new PackageWidget()
 				widgets[node.id] = pw
 
+				pw.collapseChildren(/* collapsed = */true, /* animate = */false)
+
 				stateTemplate[node.id] = pw.selectedProp
 				pw.selectionClicks.onValue(function(){
 					handleSelectionClick(node, pw)
 				})
 
-				collapsingTemplate[node.id] = pw.collapsingProp
-
-				// pw.selectedProp.log('selected ' + node.id)
-
 				pw.uiParts.collapser.click(function(event){
-					pw.collapseChildren('toggle')
+					pw.collapseChildren('toggle', true)
 					event.stopPropagation()
 				})
 
@@ -153,29 +148,6 @@
 			}
 		})
 
-		/**
-		 * Pushes a `1` event when the package widgets' collapse/expand
-		 * animation finishes. Used to update affix things since the
-		 * animation affects the page height.
-		 */
-		this.widgetsAnimating = Bacon
-			.combineTemplate(collapsingTemplate)
-			.map(function(o){
-				for(var k in o) if(o[k]) return true
-				return false
-			})
-			.skipDuplicates()
-			.toProperty(false)
-			.slidingWindow(2)
-			.filter(function(a){
-				// accepted as the 'animating' prop goes from true to false
-				if(a.length == 2 && a[0] === true && a[1] === false) return true
-				return false
-			})
-			.map(function(){ return 1 })
-
-		for(k in widgets) widgets[k].collapseChildren(true)
-
 		/**
 		 * Getter / Setter for "compact" mode, which causes the
 		 * widgets to take on a compact look.
@@ -220,7 +192,7 @@
 		function recurse(node){
 			var count = 0
 
-			if(node.kind == 'method') count += 1
+			if(node.kind == 'method') ++count
 
 			;(node.children || []).forEach(function(kid){
 				count += recurse(kid)

codepulse/src/main/resources/toserve/pages/traces/PackageWidget.js

@@ -76,8 +76,7 @@
 			_selected = 0,
 			_selectedBus = new Bacon.Bus(),
 			_collapseChildren = false,
-			_childWidgets = [],
-			_collapsingBus = new Bacon.Bus()
+			_childWidgets = []
 
 		// ============================================================================
 		// UI Selected Elements
@@ -195,19 +194,19 @@
 			return self
 		}
 
-		this.collapseChildren = function(arg){
+		this.collapseChildren = function(arg, animate){
 			if(!arguments.length) return _collapseChildren
 
 			if(arg == 'toggle') _collapseChildren = !_collapseChildren
 			else _collapseChildren = arg
 
 			updatedCollapserState()
 
-			_collapsingBus.push(true)
-			self.uiParts.childrenContainer[_collapseChildren ? 'slideUp' : 'slideDown'](
-				/* finish animation */
-				function(){ _collapsingBus.push(false) }
-			)
+			if(animate){
+				self.uiParts.childrenContainer[_collapseChildren ? 'slideUp' : 'slideDown']()
+			} else {
+				self.uiParts.childrenContainer[_collapseChildren ? 'hide' : 'show']()
+			}
 			return self
 		}
 
@@ -232,11 +231,6 @@
 		*/
 		this.selectedProp = _selectedBus.toProperty(_selected).skipDuplicates()
 
-		/*
-		Exposes (as an Rx Property) whether or not the expand/collapse animation is running
-		*/
-		this.collapsingProp = _collapsingBus.toProperty(false).skipDuplicates()
-
 		this.selectionClicks = new Bacon.Bus()
 
 		// ============================================================================