Add setting to adjust maximum file upload size

The new setting is cp.userSettings.maxFileUploadSizeMebibytes.
Restart Code Pulse after editing maxFileUploadSizeMebibytes in codepulseSettings.conf.

Author: Steve Salas

codepulse/src/main/resources/application.conf

@@ -18,12 +18,13 @@ cp {
 			codedxLoggingLevel = "INFO"
 			bootstrapLoggingLevel = "INFO"
 			liftwebLoggingLevel = "WARN"
-		}
+		},
+		maxFileUploadSizeMebibytes = 500
 	},
 	systemSettings {
 		symbolService {
 			binary = "SymbolService.exe"
 			location = "dotnet-symbol-service/publish/"
 		}
 	}
-}
+}

codepulse/src/main/resources/toserve/pages/ProjectInputForm/ProjectInputForm.js

@@ -82,15 +82,24 @@ $(document).ready(function(){
 			url: uploadUrl,
 			dropZone: fileDropzone,
 			add: function(e, data){
-                if (data.files[0].size > 524288000) {
-                    alert('The file you specified exceeds the maximum file size (500 MB).');
-                    projectFile.set(null);
-                    return
-                }
-
-                // use this `data` as the current file data.
-                // this will be used once the form is submitted.
-                projectFile.set(data)
+
+				$.ajax('/api/user-settings', {
+					error: function(xhr, status){
+						alert('Unable to fetch user settings that affect file upload')
+						projectFile.set(null)
+					},
+					success: function(userSettings){
+						if (data.files[0].size > userSettings.maxFileUploadSizeBytes) {
+							alert('The file you specified exceeds the maximum file size (' + userSettings.maxFileUploadSizeBytes / (1024*1024) + ' MB).')
+							projectFile.set(null)
+							return
+						}
+
+						// use this `data` as the current file data.
+						// this will be used once the form is submitted.
+						projectFile.set(data)
+					}
+				})
 			},
 			formData: function(){
 				var name = projectName.get()
@@ -398,4 +407,4 @@ $(document).ready(function(){
 		}
 	}
 
-})
+})

codepulse/src/main/scala/bootstrap/liftweb/FileUploadSetup.scala

@@ -22,26 +22,23 @@ package bootstrap.liftweb
 import java.io.File
 import java.io.IOException
 
-import scala.util.control.Exception.catching
+import com.secdec.codepulse.userSettings
 
+import scala.util.control.Exception.catching
 import org.apache.commons.fileupload.FileUploadBase.SizeLimitExceededException
 import org.apache.commons.io.FileUtils
 import org.apache.commons.io.FilenameUtils
 import org.apache.commons.io.IOUtils
-
 import net.liftweb.common.Loggable
 import net.liftweb.http.JsonResponse
 import net.liftweb.http.LiftRules
 import net.liftweb.http.LiftRulesMocker.toLiftRules
 import net.liftweb.json.JsonDSL.pair2jvalue
 import net.liftweb.json.JsonDSL.string2jvalue
-
 import com.secdec.codepulse.util.ManualOnDiskFileParamHolder
 
 object FileUploadSetup extends Loggable {
 
-	val MaxFileSize = 500 * 1024 * 1024
-
 	def init(liftRules: LiftRules) = {
 		setupMimeHandler(liftRules)
 		setupUploadProgress(liftRules)
@@ -56,8 +53,9 @@ object FileUploadSetup extends Loggable {
 
 	def setupMimeHandler(liftRules: LiftRules) = {
 
-		liftRules.maxMimeFileSize = MaxFileSize
-		liftRules.maxMimeSize = MaxFileSize
+		val size = userSettings.maxFileUploadSizeBytes
+		liftRules.maxMimeFileSize = size
+		liftRules.maxMimeSize = size
 
 		// Send uploaded files to a temp folder instead of putting them in memory
 		liftRules.handleMimeFile = (fieldName, contentType, fileName, stream) => {

codepulse/src/main/scala/com/secdec/codepulse/package.scala

@@ -21,17 +21,16 @@ package com.secdec
 
 import java.text.SimpleDateFormat
 import java.util.Properties
+
 import scala.collection.JavaConverters.propertiesAsScalaMapConverter
 import scala.util.Try
 import com.secdec.codepulse.util.ApplicationData
 import com.secdec.codepulse.util.Implicits._
-import com.typesafe.config.Config
-import com.typesafe.config.ConfigFactory
+import com.typesafe.config.{Config, ConfigException, ConfigFactory, ConfigRenderOptions, ConfigValueFactory}
 import java.io.File
-import com.typesafe.config.ConfigRenderOptions
 import java.io.FileWriter
+
 import ch.qos.logback.classic.Level
-import com.typesafe.config.ConfigValueFactory
 
 /** @author dylanh
   *
@@ -91,6 +90,17 @@ package object codepulse {
 			newPort
 		}
 
+		def maxFileUploadSizeBytes: Int = {
+			val mebibytes = 1024 * 1024
+			val defaultMaxSizeBytes = 500 * mebibytes
+			try {
+				val sizeMebibytes = config.getInt("cp.userSettings.maxFileUploadSizeMebibytes")
+				if (sizeMebibytes > 0) sizeMebibytes * mebibytes else defaultMaxSizeBytes
+			} catch {
+				case _: com.typesafe.config.ConfigException.Missing => defaultMaxSizeBytes
+			}
+		}
+
 		def symbolServicePort = config.getString("cp.userSettings.symbolService.port")
 
 		def skipUserAcknowledgment = config.getBoolean("cp.userSettings.skipUserAcknowledgment")

codepulse/src/main/scala/com/secdec/codepulse/tracer/APIServer.scala

@@ -460,6 +460,10 @@ class APIServer(manager: ProjectManager, treeBuilderManager: TreeBuilderManager,
 				case _ => PlainTextResponse("Unknown error.", 500)
 			}
 
+		case List("api", "user-settings") Get req =>
+			val settings: JObject = "maxFileUploadSizeBytes" -> userSettings.maxFileUploadSizeBytes
+			JsonResponse(settings)
+
 		// GET the agent string
 		case List("api", "agent-string") Get req =>
 			PlainTextResponse(ConnectionHelp.traceAgentCommand)