Anthony Robinson#6
Open
AMKRobinson wants to merge 4 commits into
Open
Conversation
finished all technical requirements
steph-dove
reviewed
Sep 12, 2017
|
|
||
| module.exports = function(name){ | ||
| if(typeof name === 'string'){ | ||
| return `hello ${name}` |
steph-dove
reviewed
Sep 12, 2017
| // } else { | ||
| // return a - b; | ||
| // } | ||
| // }; |
There was a problem hiding this comment.
remove corpse code and resubmit for full credit
steph-dove
reviewed
Sep 12, 2017
| let result = greet(123) | ||
| expect(result).toEqual(null) | ||
| console.log('number'); | ||
| }); |
There was a problem hiding this comment.
typo on line 11 . test is missing the t
There was a problem hiding this comment.
remove console logs and resubmit for full credit.
steph-dove
reviewed
Sep 12, 2017
| test('add() should return null', () => { | ||
| let result = arithmetic.sub() | ||
| expect(result).toEqual(null) | ||
| }); |
There was a problem hiding this comment.
this looks great, just remember to recheck the test massage when you copy code from a previous test. line 15 says "should return 2".
removed corpse code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.