Skip to content

Commit c43a5c4

Browse files
committed
🤖 fix: restore codecov upload for integration tests
The original condition `steps.test-filter.outputs.filter != ''` referenced a non-existent step ID, so integration test coverage was never uploaded. This was introduced in bf49482. Fix by adding an id to the test step and setting `ran=true` output when tests actually run. The codecov upload is now conditioned on this output, so it only runs when there's coverage data to upload.
1 parent 36d327c commit c43a5c4

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/pr.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,10 +121,12 @@ jobs:
121121
- uses: ./.github/actions/setup-mux
122122
- run: make build-main
123123
- name: Run integration tests
124+
id: run-tests
124125
run: |
125126
# Manual override
126127
if [[ -n "${{ github.event.inputs.test_filter }}" ]]; then
127128
TEST_INTEGRATION=1 bun x jest --coverage --maxWorkers=100% --silent ${{ github.event.inputs.test_filter }}
129+
echo "ran=true" >> "$GITHUB_OUTPUT"
128130
exit 0
129131
fi
130132
@@ -146,11 +148,12 @@ jobs:
146148
echo "Browser changes detected - running tests/ui"
147149
TEST_INTEGRATION=1 bun x jest --coverage --maxWorkers=100% --silent tests/ui/
148150
fi
151+
echo "ran=true" >> "$GITHUB_OUTPUT"
149152
env:
150153
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
151154
ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
152155
- uses: codecov/codecov-action@v5
153-
if: ${{ steps.test-filter.outputs.filter != '' }}
156+
if: steps.run-tests.outputs.ran == 'true'
154157
with:
155158
token: ${{ secrets.CODECOV_TOKEN }}
156159
files: ./coverage/lcov.info

0 commit comments

Comments
 (0)