From c43a5c4bd54dfdd1a241dc2d606cc2428e4241ee Mon Sep 17 00:00:00 2001 From: Ammar Date: Thu, 1 Jan 2026 18:45:46 -0600 Subject: [PATCH] =?UTF-8?q?=F0=9F=A4=96=20fix:=20restore=20codecov=20uploa?= =?UTF-8?q?d=20for=20integration=20tests?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The original condition `steps.test-filter.outputs.filter != ''` referenced a non-existent step ID, so integration test coverage was never uploaded. This was introduced in bf494820. Fix by adding an id to the test step and setting `ran=true` output when tests actually run. The codecov upload is now conditioned on this output, so it only runs when there's coverage data to upload. --- .github/workflows/pr.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 684529f871..9701bfae23 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -121,10 +121,12 @@ jobs: - uses: ./.github/actions/setup-mux - run: make build-main - name: Run integration tests + id: run-tests run: | # Manual override if [[ -n "${{ github.event.inputs.test_filter }}" ]]; then TEST_INTEGRATION=1 bun x jest --coverage --maxWorkers=100% --silent ${{ github.event.inputs.test_filter }} + echo "ran=true" >> "$GITHUB_OUTPUT" exit 0 fi @@ -146,11 +148,12 @@ jobs: echo "Browser changes detected - running tests/ui" TEST_INTEGRATION=1 bun x jest --coverage --maxWorkers=100% --silent tests/ui/ fi + echo "ran=true" >> "$GITHUB_OUTPUT" env: OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }} - uses: codecov/codecov-action@v5 - if: ${{ steps.test-filter.outputs.filter != '' }} + if: steps.run-tests.outputs.ran == 'true' with: token: ${{ secrets.CODECOV_TOKEN }} files: ./coverage/lcov.info