From 3ba07458667a3e9467d6a2468b3d222a2e33fa16 Mon Sep 17 00:00:00 2001 From: schlumphi Date: Sun, 8 Feb 2026 15:41:26 +0100 Subject: [PATCH 1/2] feat: max-of-vector task done --- homework/max-of-vector/maxOfVector.hpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/homework/max-of-vector/maxOfVector.hpp b/homework/max-of-vector/maxOfVector.hpp index f82fb2a1..3d7de243 100644 --- a/homework/max-of-vector/maxOfVector.hpp +++ b/homework/max-of-vector/maxOfVector.hpp @@ -3,6 +3,11 @@ #include int maxOfVector(const std::vector& vec) { - // TODO: Implement me :) - return {}; + auto max(vec.front()); + for (const auto elem : vec) { + if (elem >= max) { + max = elem; + } + } + return max; } From 07a9a682ae12f6507ec736f53ab902538a0ecce0 Mon Sep 17 00:00:00 2001 From: schlumphi Date: Sun, 8 Feb 2026 15:46:34 +0100 Subject: [PATCH 2/2] fix: edge case when input vector is empty --- homework/max-of-vector/maxOfVector.hpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/homework/max-of-vector/maxOfVector.hpp b/homework/max-of-vector/maxOfVector.hpp index 3d7de243..7cc61b16 100644 --- a/homework/max-of-vector/maxOfVector.hpp +++ b/homework/max-of-vector/maxOfVector.hpp @@ -3,6 +3,10 @@ #include int maxOfVector(const std::vector& vec) { + if (vec.empty()) { + return std::numeric_limits::min(); + } + auto max(vec.front()); for (const auto elem : vec) { if (elem >= max) {