feat: Added kill listeners so process gets killed properly

Author: kevinwang5658

src/plugins/plugin-manager.ts

@@ -35,6 +35,8 @@ export class PluginManager {
       this.plugins.set(plugin.name, plugin)
     }
 
+    this.registerKillListeners(plugins)
+
     const dependencyMap = await this.initializePlugins(plugins, secureMode);
     return dependencyMap;
   }
@@ -174,4 +176,19 @@ export class PluginManager {
 
     return resourceMap;
   }
+
+  /** Clean up any stranglers and child processes if the CLI is killed */
+  private registerKillListeners(plugins: Plugin[]) {
+    const kill = (code) => {
+      plugins.forEach((p) => {
+        p.kill()
+      })
+      process.exit(code);
+    }
+
+    process.on('exit', kill)
+    process.on('SIGINT', kill)
+    process.on('SIGTERM', kill)
+    process.on('SIGHUP', kill)
+  }
 }

src/plugins/plugin-process.ts

@@ -115,6 +115,10 @@ export class PluginProcess {
 
   private static isIpcMessage(message: unknown): message is IpcMessageV2 {
     return ipcMessageValidator(message);
-  } 
+  }
+
+  kill() {
+    this.process.kill(9)
+  }
 }
 

src/plugins/plugin.ts

@@ -131,6 +131,10 @@ export class Plugin implements IPlugin {
     }
   }
 
+  kill() {
+    this.process?.kill()
+  }
+
   private validateInitializeResponse(response: unknown): response is InitializeResponseData {
     return initializeResponseValidator(response)
   }

src/ui/reporters/default-reporter.tsx

@@ -44,7 +44,7 @@ export class DefaultReporter implements Reporter {
     ctx.on(Event.PROCESS_START, (name) => this.onProcessStartEvent(name))
     ctx.on(Event.PROCESS_FINISH, (name) => this.onProcessFinishEvent(name))
     ctx.on(Event.SUB_PROCESS_START, (name, additionalName) => this.onSubprocessStartEvent(name, additionalName));
-    ctx.on(Event.SUB_PROCESS_FINISH, (name, additionalName) => this.onSubprocessFinishEvent(name, additionalName))
+    ctx.on(Event.SUB_PROCESS_FINISH, (name, additionalName) => this.onSubprocessFinishEvent(name, additionalName));
   }
 
   async promptUserForValues(resources: Array<ResourceInfo>, promptType: PromptType): Promise<ResourceConfig[]> {