Remove deprecated type hints #338
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…onex/aiosmtplib into remove-deprecated-type-hints
Author
|
Seeing how this library tests for uvloop I was wondering if I could add winloop to the mix in a later pull request? |
Owner
|
This looks great, thanks for the cleanup! Do you mind signing your commits, sorry that's a check I've been meaning to have in place for some time. I'd accept a change to add winloop to the test suite, I think you should be able to follow the uvloop setup. |
Signed-off-by: Vizonex <VizonexBusiness@gmail.com>
Author
|
I just needed to sign it I don't know exactly how to sign the others off since I've never signed commits before I did this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used ruff to upgrade the current codebase since 3.9 is not supported anymore and since
typing.Unionandtyping.Optionalare both deprecated I saw something that could be easily fixed up.