Line ending problem while pushing a change

[kaj-se]

Problem

I had the problem that my system changed the line endings from LF (UNIX) to CRLF (Windows), which caused problems while pushing my changes.

Context

We should make it clear that only files/changes with LF (Unix) line endings will be accepted.

---

Edit:

[seanmakesgames]

I think this can be enforced programmatically through a linter or other source control setting. It should not be written in the readme or asked of reviewers or contributors to remember.

Is the issue that you were able to push the changes with changed line endings or that you couldn't and it was confusing?

Please change the title from a solution-style title, to a problem-oriented title.

[seanmakesgames]

thanks for changing the title.

Can you clarify your situation?
Did your changes get prevented from being pushed up? Did the CI prevent stuff? What did the error message look like?

[kaj-se]

Problem

The thing is, when I open Github Desktop (on my Windows system), the line ending got changed from LF (\n, 0x0A) to CRLF (\r\n, 0x0D 0x0A), which results in a warning message in the application. Could also confirm that with hexedit.

That's strange, because my text editor is set to Unix line ending when I edited and saved the SFD-file. I also have automatic end of line detection activated (yes, the original file of @hmdunce used Unlix line ending).

Radslut → End of Line, Automatisk detektering av Radslut → Automatic end of line detection

I found out that FontForge uses the line ending that is used by the main system, for Windows it's CRLF and for Unix systems like Linux it's LF. That leads to mixing the line endings. The fact that CRLF would be one byte more each line should lead to the use of only LF. For the SFD-file with ger-scanthis would result in a 7509 bytes overhead.

Idea

• Tell the contributer in the README.md to only use LF for all files in the repo.
• A repo script that will do this verification automatically and also do a correction if needed.

[kaj-se]

I think this can be enforced programmatically through a linter or other source control setting. It should not be written in the readme or asked of reviewers or contributors to remember.

@hmdunce can you setup this to enforce/correcting the line ending to LF - 0x0A, so it dons't metter if a pull request has CRLF 0x0D 0x0A or LF 0x0A?