From 751c3a1975bcae627103bd0e591090bd380d5a4f Mon Sep 17 00:00:00 2001 From: Harendra Kumar Date: Wed, 15 Apr 2026 21:33:56 +0530 Subject: [PATCH 1/5] Add download instructions in local build --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index a542b3b..474f01e 100644 --- a/README.md +++ b/README.md @@ -24,7 +24,8 @@ Easiest way to try it out is to download the `packcheck.sh` script and run it from within your Haskell package repo locally. ```bash -packcheck.sh cabal +curl -sLO https://raw.githubusercontent.com/composewell/packcheck/master/packcheck.sh +bash packcheck.sh cabal ``` ### Running in GitHub Actions From 5da439596610065afc7853a91ecc6da4aca3efc7 Mon Sep 17 00:00:00 2001 From: Harendra Kumar Date: Wed, 15 Apr 2026 21:34:23 +0530 Subject: [PATCH 2/5] Update cabal-version and tested-with --- packcheck.cabal | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/packcheck.cabal b/packcheck.cabal index bf1012d..f72d8e0 100644 --- a/packcheck.cabal +++ b/packcheck.cabal @@ -1,3 +1,4 @@ +cabal-version: 2.2 name: packcheck version: 0.7.1 synopsis: Universal build and CI testing for Haskell packages @@ -27,7 +28,7 @@ description: homepage: https://github.com/composewell/packcheck bug-reports: https://github.com/composewell/packcheck/issues -license: BSD3 +license: BSD-3-Clause license-file: LICENSE tested-with: GHC==9.14.1 @@ -35,17 +36,12 @@ tested-with: , GHC==9.10.3 , GHC==9.8.4 , GHC==9.6.3 - , GHC==9.4.8 - , GHC==9.2.8 - , GHC==9.0.1 - , GHC==8.10.7 author: Harendra Kumar maintainer: harendra.kumar@gmail.com copyright: 2017 Harendra Kumar category: Testing, CI stability: Experimental build-type: Simple -cabal-version: 1.18 extra-doc-files: Changelog.md From 2026dbacf8bd9a91c25c067006bcc9e5587107df Mon Sep 17 00:00:00 2001 From: Harendra Kumar Date: Wed, 15 Apr 2026 21:36:36 +0530 Subject: [PATCH 3/5] Add configure.ac for testing confiigure builds It requires autoreconf on the system for SDIST build. --- configure.ac | 15 +++++++++++++++ packcheck.cabal | 1 + 2 files changed, 16 insertions(+) create mode 100644 configure.ac diff --git a/configure.ac b/configure.ac new file mode 100644 index 0000000..7fbe175 --- /dev/null +++ b/configure.ac @@ -0,0 +1,15 @@ +# Input file for autoconf to generate the configure script. + +# See https://www.gnu.org/software/autoconf/manual/autoconf.html for help on +# the macros used in this file. + +AC_INIT([packcheck], [0.7.1], [streamly@composewell.com], [streamly], [https://streamly.composewell.com]) + +# To suppress "WARNING: unrecognized options: --with-compiler" +AC_ARG_WITH([compiler], [GHC]) + +# ----------------------------------------------------------------------------- +# Output +# ----------------------------------------------------------------------------- +AC_CONFIG_HEADERS([src/config.h]) +AC_OUTPUT diff --git a/packcheck.cabal b/packcheck.cabal index f72d8e0..094be63 100644 --- a/packcheck.cabal +++ b/packcheck.cabal @@ -49,6 +49,7 @@ extra-doc-files: README.md extra-source-files: + configure.ac packcheck.sh packcheck-remote.sh From b1e24f297b363ce6ffb757dda72f7b63a42acc0d Mon Sep 17 00:00:00 2001 From: Harendra Kumar Date: Wed, 15 Apr 2026 21:43:43 +0530 Subject: [PATCH 4/5] Disable sdist build on macOS and Windows, by default --- .github/workflows/packcheck.yml | 8 +++++++- appveyor.yml | 5 ++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/.github/workflows/packcheck.yml b/.github/workflows/packcheck.yml index 3857237..0681aef 100644 --- a/.github/workflows/packcheck.yml +++ b/.github/workflows/packcheck.yml @@ -171,9 +171,13 @@ jobs: runner: macos-latest command: cabal ghc_version: 9.12.4 + # autoreconf required by SDIST build when a configure script + # is present, is not available by default on Windows, so + # disable it. # WARNING! cannot use # comments inside pack_options. pack_options: >- CABAL_PROJECT=cabal.project + DISABLE_SDIST_BUILD=y - name: ci runner: ubuntu-latest @@ -212,8 +216,10 @@ jobs: runner: windows-latest command: cabal ghc_version: 9.14.1 + # On Windows, DISABLE_SDIST_BUILD is useful for (1) avoiding + # path length restriction, (2) avoid installing autoreconf + # for configure builds. # WARNING! cannot use # comments inside pack_options. - # DISABLE_SDIST_BUILD for shorter paths on Windows pack_options: >- DISABLE_SDIST_BUILD="y" CABAL_PROJECT=cabal.project diff --git a/appveyor.yml b/appveyor.yml index 0bbed62..f6c3380 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -33,7 +33,10 @@ environment: # DISABLE_BENCH: "y" # DISABLE_DOCS: "y" # DISABLE_DIST_CHECKS: "y" - # DISABLE_SDIST_BUILD: "y" + # On Windows, DISABLE_SDIST_BUILD is useful for (1) avoiding + # path length restriction, (2) avoid installing autoreconf + # for configure builds. + DISABLE_SDIST_BUILD: "y" # Note: these require the "diff" utility. # DISABLE_SDIST_GIT_CHECK: "y" DISABLE_SDIST_PROJECT_CHECK: "y" From dd9ba87d2a42c7cd1d96e3946636c07e732587b4 Mon Sep 17 00:00:00 2001 From: Harendra Kumar Date: Wed, 15 Apr 2026 22:24:05 +0530 Subject: [PATCH 5/5] Install autoconf on circleci --- .circleci/config.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index e3ac7cc..ce911d9 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -92,6 +92,9 @@ preinstall: &preinstall #apt-get install -y ghc-8.10.4 #apt-get install -y cabal-install-3.4 + # If you have a configure.ac script and have sdist build enabled + apt-get install -y autoconf + # required for outbound https for stack and for stack setup apt-get install -y netbase xz-utils make apt-get install -y zlib1g-dev