Skip to content

Commit f857b4e

Browse files
nadeem-csnadeem-cs
authored
Merge pull request #131 from contentstack/feat/DX-3895-Remove-ContentType-Header-Delete-Release
Bump version to 0.6.1 and fix DELETE request headers
2 parents 09db494 + be9b545 commit f857b4e

8 files changed

Lines changed: 206 additions & 8 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
## [v0.6.1](https://github.com/contentstack/contentstack-management-dotnet/tree/v0.6.1) (2026-02-02)
4+
- Fix
5+
- Release DELETE request no longer includes Content-Type header to comply with API requirements
6+
37
## [v0.6.0](https://github.com/contentstack/contentstack-management-dotnet/tree/v0.6.0)
48
- Enhancement
59
- Refactor retry policy implementation to improve exception handling and retry logic across various scenarios

‎Contentstack.Management.Core.Tests/IntegrationTest/Contentstack004_ReleaseTest.cs‎

Lines changed: 86 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -970,6 +970,92 @@ public async Task Test020_Should_Delete_Release_Async()
970970
}
971971
}
972972

973+
/// <summary>
974+
/// Verifies that Delete Release API succeeds when the SDK does not send Content-Type header (DELETE /releases/{uid}).
975+
/// Creates a release, deletes it without Content-Type, asserts success, then verifies the release is gone.
976+
/// </summary>
977+
[TestMethod]
978+
[DoNotParallelize]
979+
public void Test021_Should_Delete_Release_Without_Content_Type_Header()
980+
{
981+
try
982+
{
983+
var releaseModel = new ReleaseModel
984+
{
985+
Name = _testReleaseName + " Delete Without Content-Type",
986+
Description = _testReleaseDescription + " (Delete without Content-Type header)",
987+
Locked = false,
988+
Archived = false
989+
};
990+
991+
ContentstackResponse createResponse = _stack.Release().Create(releaseModel);
992+
var createResponseJson = createResponse.OpenJObjectResponse();
993+
Assert.IsTrue(createResponse.IsSuccessStatusCode, "Create release must succeed.");
994+
string releaseToDeleteUid = createResponseJson["release"]["uid"].ToString();
995+
996+
ContentstackResponse deleteResponse = _stack.Release(releaseToDeleteUid).Delete();
997+
998+
Assert.IsNotNull(deleteResponse);
999+
Assert.IsTrue(deleteResponse.IsSuccessStatusCode, "Delete release (without Content-Type) must succeed.");
1000+
1001+
try
1002+
{
1003+
var fetchResponse = _stack.Release(releaseToDeleteUid).Fetch();
1004+
Assert.IsFalse(fetchResponse.IsSuccessStatusCode, "Release must be gone after delete; Fetch should not succeed.");
1005+
}
1006+
catch (ContentstackErrorException)
1007+
{
1008+
Assert.IsTrue(true, "Release not found after delete (exception path).");
1009+
}
1010+
}
1011+
catch (Exception e)
1012+
{
1013+
Assert.Fail($"Delete release without Content-Type header failed: {e.Message}");
1014+
}
1015+
}
9731016

1017+
/// <summary>
1018+
/// Verifies that Delete Release API (async) succeeds when the SDK does not send Content-Type header (DELETE /releases/{uid}).
1019+
/// Creates a release, deletes it without Content-Type, asserts success, then verifies the release is gone.
1020+
/// </summary>
1021+
[TestMethod]
1022+
[DoNotParallelize]
1023+
public async Task Test022_Should_Delete_Release_Async_Without_Content_Type_Header()
1024+
{
1025+
try
1026+
{
1027+
var releaseModel = new ReleaseModel
1028+
{
1029+
Name = _testReleaseName + " Delete Async Without Content-Type",
1030+
Description = _testReleaseDescription + " (Delete async without Content-Type header)",
1031+
Locked = false,
1032+
Archived = false
1033+
};
1034+
1035+
ContentstackResponse createResponse = await _stack.Release().CreateAsync(releaseModel);
1036+
var createResponseJson = createResponse.OpenJObjectResponse();
1037+
Assert.IsTrue(createResponse.IsSuccessStatusCode, "Create release must succeed.");
1038+
string releaseToDeleteUid = createResponseJson["release"]["uid"].ToString();
1039+
1040+
ContentstackResponse deleteResponse = await _stack.Release(releaseToDeleteUid).DeleteAsync();
1041+
1042+
Assert.IsNotNull(deleteResponse);
1043+
Assert.IsTrue(deleteResponse.IsSuccessStatusCode, "Delete release async (without Content-Type) must succeed.");
1044+
1045+
try
1046+
{
1047+
var fetchResponse = await _stack.Release(releaseToDeleteUid).FetchAsync();
1048+
Assert.IsFalse(fetchResponse.IsSuccessStatusCode, "Release must be gone after delete; Fetch should not succeed.");
1049+
}
1050+
catch (ContentstackErrorException)
1051+
{
1052+
Assert.IsTrue(true, "Release not found after delete (exception path).");
1053+
}
1054+
}
1055+
catch (Exception e)
1056+
{
1057+
Assert.Fail($"Delete release async without Content-Type header failed: {e.Message}");
1058+
}
1059+
}
9741060
}
9751061
}

‎Contentstack.Management.Core.Unit.Tests/Core/Services/ContentstackServiceTest.cs‎

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using System;
1+
using System;
22
using System.Collections.Generic;
33
using System.Globalization;
44
using System.IO;
@@ -279,6 +279,19 @@ public void Return_Value_For_HeaderKey()
279279
Assert.AreEqual("application/json", contentstackService.GetHeaderValue(HeadersKey.ContentTypeHeader));
280280
}
281281

282+
[TestMethod]
283+
public void CreateHttpRequest_Should_Set_Content_Type_When_ShouldSetContentType_Returns_True()
284+
{
285+
var contentstackService = new ContentstackService(serializer);
286+
var config = new ContentstackClientOptions();
287+
config.Authtoken = _fixture.Create<string>();
288+
289+
contentstackService.CreateHttpRequest(new HttpClient(), config);
290+
291+
Assert.IsTrue(contentstackService.Headers.ContainsKey(HeadersKey.ContentTypeHeader));
292+
Assert.AreEqual("application/json", contentstackService.GetHeaderValue(HeadersKey.ContentTypeHeader));
293+
}
294+
282295
[TestMethod]
283296
public void Return_HttpRequest_On_Create_HttpRequest()
284297
{

‎Contentstack.Management.Core.Unit.Tests/Core/Services/Models/FetchDeleteServiceTest.cs‎

Lines changed: 70 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,28 @@
1-
using System;
1+
using System;
2+
using System.Net.Http;
23
using AutoFixture;
34
using AutoFixture.AutoMoq;
5+
using Contentstack.Management.Core;
46
using Contentstack.Management.Core.Services.Models;
7+
using Contentstack.Management.Core.Utils;
58
using Microsoft.VisualStudio.TestTools.UnitTesting;
69
using Newtonsoft.Json;
10+
711
namespace Contentstack.Management.Core.Unit.Tests.Core.Services.Models
812
{
913
[TestClass]
1014
public class FetchDeleteServiceTest
1115
{
1216
private JsonSerializer serializer = JsonSerializer.Create(new JsonSerializerSettings());
1317
private readonly IFixture _fixture = new Fixture()
14-
.Customize(new AutoMoqCustomization());
18+
.Customize(new AutoMoqCustomization());
1519

20+
private static ContentstackClientOptions CreateConfig(IFixture fixture)
21+
{
22+
var config = new ContentstackClientOptions();
23+
config.Authtoken = fixture.Create<string>();
24+
return config;
25+
}
1626

1727
[TestMethod]
1828
public void Should_Throw_On_Null_Serializer()
@@ -60,5 +70,63 @@ public void Should_Provide_Valid_Param_On_Initialize()
6070
Assert.AreEqual("GET", service.HttpMethod);
6171
Assert.AreEqual(resourcePath, service.ResourcePath);
6272
}
73+
74+
[TestMethod]
75+
public void Delete_Release_Should_Not_Include_Content_Type_Header()
76+
{
77+
var stack = new Management.Core.Models.Stack(null, _fixture.Create<string>());
78+
var service = new FetchDeleteService(serializer, stack, "/releases/release_uid_123", "DELETE");
79+
80+
service.CreateHttpRequest(new HttpClient(), CreateConfig(_fixture));
81+
82+
Assert.IsFalse(service.Headers.ContainsKey(HeadersKey.ContentTypeHeader), "DELETE /releases/{uid} must not include Content-Type header.");
83+
}
84+
85+
[TestMethod]
86+
public void Delete_Release_With_Path_Releases_Only_Should_Not_Include_Content_Type_Header()
87+
{
88+
var stack = new Management.Core.Models.Stack(null, _fixture.Create<string>());
89+
var service = new FetchDeleteService(serializer, stack, "/releases", "DELETE");
90+
91+
service.CreateHttpRequest(new HttpClient(), CreateConfig(_fixture));
92+
93+
Assert.IsFalse(service.Headers.ContainsKey(HeadersKey.ContentTypeHeader));
94+
}
95+
96+
[TestMethod]
97+
public void Delete_Release_Items_Path_Should_Include_Content_Type_Header()
98+
{
99+
var stack = new Management.Core.Models.Stack(null, _fixture.Create<string>());
100+
var service = new FetchDeleteService(serializer, stack, "/releases/release_uid/item", "DELETE");
101+
102+
service.CreateHttpRequest(new HttpClient(), CreateConfig(_fixture));
103+
104+
Assert.IsTrue(service.Headers.ContainsKey(HeadersKey.ContentTypeHeader), "DELETE /releases/{uid}/item (FetchDeleteService) should still set Content-Type.");
105+
Assert.AreEqual("application/json", service.GetHeaderValue(HeadersKey.ContentTypeHeader));
106+
}
107+
108+
[TestMethod]
109+
public void Fetch_Release_Should_Include_Content_Type_Header()
110+
{
111+
var stack = new Management.Core.Models.Stack(null, _fixture.Create<string>());
112+
var service = new FetchDeleteService(serializer, stack, "/releases/release_uid_123", "GET");
113+
114+
service.CreateHttpRequest(new HttpClient(), CreateConfig(_fixture));
115+
116+
Assert.IsTrue(service.Headers.ContainsKey(HeadersKey.ContentTypeHeader));
117+
Assert.AreEqual("application/json", service.GetHeaderValue(HeadersKey.ContentTypeHeader));
118+
}
119+
120+
[TestMethod]
121+
public void Delete_Non_Release_Resource_Should_Include_Content_Type_Header()
122+
{
123+
var stack = new Management.Core.Models.Stack(null, _fixture.Create<string>());
124+
var service = new FetchDeleteService(serializer, stack, "/contenttypes/ct_uid", "DELETE");
125+
126+
service.CreateHttpRequest(new HttpClient(), CreateConfig(_fixture));
127+
128+
Assert.IsTrue(service.Headers.ContainsKey(HeadersKey.ContentTypeHeader));
129+
Assert.AreEqual("application/json", service.GetHeaderValue(HeadersKey.ContentTypeHeader));
130+
}
63131
}
64132
}

‎Contentstack.Management.Core.Unit.Tests/Models/ReleaseTest.cs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
using System;
1+
using System;
22
using AutoFixture;
3+
using Contentstack.Management.Core;
34
using Contentstack.Management.Core.Models;
45
using Contentstack.Management.Core.Queryable;
56
using Contentstack.Management.Core.Unit.Tests.Mokes;

‎Contentstack.Management.Core/Services/ContentstackService.cs‎

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using System;
1+
using System;
22
using System.IO;
33
using System.Text;
44
using System.Net.Http;
@@ -151,6 +151,15 @@ public bool HasRequestBody()
151151
return HttpMethod == "POST" || HttpMethod == "PUT" || HttpMethod == "PATCH" || HttpMethod == "DELETE";
152152
}
153153

154+
/// <summary>
155+
/// Returns true if the request should include Content-Type: application/json header.
156+
/// Override to skip Content-Type for specific requests (e.g. DELETE /releases).
157+
/// </summary>
158+
protected virtual bool ShouldSetContentType()
159+
{
160+
return true;
161+
}
162+
154163
public virtual IHttpRequest CreateHttpRequest(HttpClient httpClient, ContentstackClientOptions config, bool addAcceptMediaHeader = false, string apiVersion = null)
155164
{
156165
ThrowIfDisposed();
@@ -162,7 +171,10 @@ public virtual IHttpRequest CreateHttpRequest(HttpClient httpClient, Contentstac
162171
.Add(new MediaTypeWithQualityHeaderValue("image/jpeg"));
163172
}
164173
Uri requestUri = ContentstackUtilities.ComposeUrI(config.GetUri(), this);
165-
Headers["Content-Type"] = "application/json";
174+
if (ShouldSetContentType())
175+
{
176+
Headers["Content-Type"] = "application/json";
177+
}
166178

167179
if (!string.IsNullOrEmpty(this.ManagementToken))
168180
{

‎Contentstack.Management.Core/Services/Models/FetchDeleteService.cs‎

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using System;
1+
using System;
22
using Contentstack.Management.Core.Queryable;
33
using Newtonsoft.Json;
44
using Contentstack.Management.Core.Utils;
@@ -29,5 +29,19 @@ internal FetchDeleteService(JsonSerializer serializer, Core.Models.Stack stack,
2929
}
3030
}
3131
#endregion
32+
33+
/// <summary>
34+
/// Skip Content-Type for DELETE /releases (single release delete). Keep it for DELETE /releases/{uid}/item and other requests.
35+
/// </summary>
36+
protected override bool ShouldSetContentType()
37+
{
38+
if (HttpMethod != "DELETE" || string.IsNullOrEmpty(ResourcePath))
39+
return true;
40+
if (!ResourcePath.StartsWith("/releases", StringComparison.Ordinal))
41+
return true;
42+
if (ResourcePath.EndsWith("/item", StringComparison.Ordinal))
43+
return true;
44+
return false;
45+
}
3246
}
3347
}

‎Directory.Build.props‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<Project>
22
<PropertyGroup>
3-
<Version>0.6.0</Version>
3+
<Version>0.6.1</Version>
44
</PropertyGroup>
55
</Project>

0 commit comments

Comments
 (0)