The workflow now skips checks for PRs with only test/docs changes

Author: harshitha-cstk

.github/workflows/check-version-bump.yml

@@ -1,13 +1,9 @@
-# Ensures package.json and CHANGELOG.md are bumped when merging to release branch (master/main).
-# Runs only on PRs targeting master or main (e.g. development → master).
+# Catches when developers forget to add a version bump for their changes.
+# Code changes (e.g. lib/) require package.json + CHANGELOG.md; test-only or comment-only in lib/ skip.
 name: Check Version Bump
 
 on:
   pull_request:
-    branches:
-      - master
-      - main
-      - development
 
 jobs:
   version-bump:
@@ -19,36 +15,45 @@ jobs:
         with:
           fetch-depth: 0
 
+      - name: Detect changed files and version bump
+        id: detect
+        run: |
+          if git rev-parse HEAD^2 >/dev/null 2>&1; then
+            FILES=$(git diff --name-only HEAD^1 HEAD^2)
+          else
+            FILES=$(git diff --name-only HEAD~1 HEAD)
+          fi
+          VERSION_FILES_CHANGED=false
+          echo "$FILES" | grep -qx 'package.json' && VERSION_FILES_CHANGED=true
+          echo "$FILES" | grep -qx 'CHANGELOG.md' && VERSION_FILES_CHANGED=true
+          echo "version_files_changed=$VERSION_FILES_CHANGED" >> $GITHUB_OUTPUT
+          CODE_CHANGED=false
+          echo "$FILES" | grep -qE '^lib/|^webpack/|^dist/' && CODE_CHANGED=true
+          echo "$FILES" | grep -qx 'package.json' && CODE_CHANGED=true
+          echo "code_changed=$CODE_CHANGED" >> $GITHUB_OUTPUT
+
+      - name: Skip when only test/docs/config changed
+        if: steps.detect.outputs.code_changed != 'true'
+        run: |
+          echo "No release-affecting files changed (e.g. only test/docs). Skipping version-bump check."
+          exit 0
+
+      - name: Fail when version bump was missed
+        if: steps.detect.outputs.code_changed == 'true' && steps.detect.outputs.version_files_changed != 'true'
+        run: |
+          echo "::error::This PR has code changes but no version bump. Please bump the version in package.json and add an entry in CHANGELOG.md."
+          exit 1
+
       - name: Setup Node
+        if: steps.detect.outputs.code_changed == 'true' && steps.detect.outputs.version_files_changed == 'true'
         uses: actions/setup-node@v4
         with:
           node-version: '22.x'
 
       - name: Check version bump
-        env:
-          BASE_SHA: ${{ github.event.pull_request.base.sha }}
+        if: steps.detect.outputs.code_changed == 'true' && steps.detect.outputs.version_files_changed == 'true'
         run: |
           set -e
-          # Skip version bump check when only test/docs/config files changed (no production code)
-          if [ -n "$BASE_SHA" ]; then
-            CHANGED=$(git diff --name-only "$BASE_SHA" HEAD 2>/dev/null || true)
-            PROD_CHANGES=$(echo "$CHANGED" | grep -v -e '^test/' -e '^package\.json$' -e '^CHANGELOG\.md$' -e '^\.github/' -e '^README' -e '^\.' -e '^docs/' -e '^jest\.config' -e '^\.eslintrc' -e '^\.prettierrc' || true)
-            PROD_CHANGES=$(echo "$PROD_CHANGES" | sed '/^$/d')
-            if [ -z "$PROD_CHANGES" ]; then
-              echo "Only test/docs/config files changed. Skipping version bump check."
-              exit 0
-            fi
-            # Skip when only comments changed in production files (//, /*, *, */, #)
-            if git diff "$BASE_SHA" HEAD | node -e "
-              const lines = require('fs').readFileSync(0,'utf8').split('\n').filter(l=>l.startsWith('+')||l.startsWith('-'));
-              const isComment = (s) => { const t=(s||'').slice(1).replace(/^\s+|\s+$/g,''); return !t || /^\/\//.test(t) || /^\/\*/.test(t) || /^\*\//.test(t) || /^\s*\*/.test(t) || /^#/.test(t); };
-              const hasCode = lines.some(l => !isComment(l));
-              process.exit(hasCode ? 1 : 0);
-            " 2>/dev/null; then
-              echo "Only comments changed in code. Skipping version bump check."
-              exit 0
-            fi
-          fi
           PKG_VERSION=$(node -p "require('./package.json').version.replace(/^v/, '')")
           if [ -z "$PKG_VERSION" ]; then
             echo "::error::Could not read version from package.json"