From 7f7dd023a4a7aedeff38a352de742388e1adaa34 Mon Sep 17 00:00:00 2001 From: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com> Date: Mon, 2 Mar 2026 15:14:47 -0800 Subject: [PATCH 1/3] Make lint mandatory for integration and deploy_website Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com> --- .github/workflows/test-build-deploy.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test-build-deploy.yml b/.github/workflows/test-build-deploy.yml index 1d3608613a..427bea78ed 100644 --- a/.github/workflows/test-build-deploy.yml +++ b/.github/workflows/test-build-deploy.yml @@ -170,7 +170,7 @@ jobs: path: ./images.tar integration: - needs: build + needs: [build, lint] runs-on: ${{ matrix.runner }} timeout-minutes: 50 strategy: @@ -295,7 +295,7 @@ jobs: IMAGE_PREFIX: ${{ secrets.IMAGE_PREFIX }} integration-configs-db: - needs: build + needs: [build, lint] runs-on: ${{ matrix.runner }} timeout-minutes: 20 strategy: @@ -327,7 +327,7 @@ jobs: make BUILD_IMAGE=quay.io/cortexproject/build-image:master-8b48921f71 TTY='' configs-integration-test deploy_website: - needs: [build, test] + needs: [build, test, lint] if: github.ref == 'refs/heads/master' && github.repository == 'cortexproject/cortex' runs-on: ubuntu-24.04 container: From dcf5985394b131f96dc0456bf590f14129da206a Mon Sep 17 00:00:00 2001 From: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com> Date: Mon, 2 Mar 2026 15:56:42 -0800 Subject: [PATCH 2/3] Add linting bug Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com> --- cmd/cortex/main.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cmd/cortex/main.go b/cmd/cortex/main.go index d8a4867752..646f095b0f 100644 --- a/cmd/cortex/main.go +++ b/cmd/cortex/main.go @@ -191,6 +191,8 @@ func main() { // Initialise seed for randomness usage. rand.New(rand.NewSource(time.Now().UnixNano())) + err = nil + t, err := cortex.New(cfg) util_log.CheckFatal("initializing cortex", err) From fd649c1e177740e96281f24894309a5014d31701 Mon Sep 17 00:00:00 2001 From: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com> Date: Mon, 2 Mar 2026 16:02:54 -0800 Subject: [PATCH 3/3] Revert "Add linting bug" This reverts commit dcf5985394b131f96dc0456bf590f14129da206a. Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com> --- cmd/cortex/main.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/cmd/cortex/main.go b/cmd/cortex/main.go index 646f095b0f..d8a4867752 100644 --- a/cmd/cortex/main.go +++ b/cmd/cortex/main.go @@ -191,8 +191,6 @@ func main() { // Initialise seed for randomness usage. rand.New(rand.NewSource(time.Now().UnixNano())) - err = nil - t, err := cortex.New(cfg) util_log.CheckFatal("initializing cortex", err)