lint

Author: y-lakhdar

src/main/java/com/coveo/pushapiclient/CatalogStreamUploadHandler.java

@@ -26,8 +26,7 @@ public HttpResponse<String> uploadAndPush(StreamUpdate stream)
 
     // Step 2: Upload content to container
     String batchUpdateJson = new Gson().toJson(stream.marshal());
-    logger.debug(
-        "Uploading stream content to file container: {}", container.fileId);
+    logger.debug("Uploading stream content to file container: {}", container.fileId);
     platformClient.uploadContentToFileContainer(container, batchUpdateJson);
 
     // Step 3: Push container to stream source

src/main/java/com/coveo/pushapiclient/StreamDocumentUploadQueue.java

@@ -90,6 +90,7 @@ public boolean isEmpty() {
 
   /**
    * Returns the HTTP response from the last flush operation.
+   *
    * @return The last response, or null if no flush has occurred or queue was empty.
    */
   HttpResponse<String> getLastResponse() {

src/main/java/com/coveo/pushapiclient/StreamUploadHandler.java

@@ -7,6 +7,7 @@
  * Functional interface for stream upload operations with a three-step workflow contract.
  *
  * <p>Implementations of this interface handle the complete stream upload workflow:
+ *
  * <ol>
  *   <li>Create a file container via {@code platformClient.createFileContainer()}
  *   <li>Upload content to the container via {@code platformClient.uploadContentToFileContainer()}

src/main/java/com/coveo/pushapiclient/UpdateStreamService.java

@@ -11,7 +11,6 @@ public class UpdateStreamService {
   private final PlatformClient platformClient;
   private final UpdateStreamServiceInternal updateStreamServiceInternal;
 
-
   /**
    * Creates a service to stream your documents to the provided source by interacting with the
    * Stream API. This provides the ability to incrementally add, update, or delete documents via a

src/main/java/com/coveo/pushapiclient/UpdateStreamServiceInternal.java

@@ -17,8 +17,7 @@ public UpdateStreamServiceInternal(
     this.queue = queue;
   }
 
-  public void addOrUpdate(DocumentBuilder document)
-      throws IOException, InterruptedException {
+  public void addOrUpdate(DocumentBuilder document) throws IOException, InterruptedException {
     queue.add(document);
   }
 

src/test/java/com/coveo/pushapiclient/CatalogStreamUploadHandlerTest.java

@@ -1,8 +1,12 @@
 package com.coveo.pushapiclient;
 
-import static org.junit.Assert.*;
-import static org.mockito.ArgumentMatchers.*;
-import static org.mockito.Mockito.*;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertSame;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.inOrder;
+import static org.mockito.Mockito.when;
 
 import com.google.gson.JsonObject;
 import java.io.IOException;
@@ -42,8 +46,7 @@ public void uploadAndPushShouldExecute3StepWorkflowInOrder()
     when(mockContainerResponse.body()).thenReturn("{\"fileId\":\"test-container-id\"}");
     when(mockPlatformClient.createFileContainer()).thenReturn(mockContainerResponse);
     StreamUpdateRecord mockRecord =
-        new StreamUpdateRecord(
-            new JsonObject[] {}, new JsonObject[] {}, new JsonObject[] {});
+        new StreamUpdateRecord(new JsonObject[] {}, new JsonObject[] {}, new JsonObject[] {});
     when(mockStreamUpdate.marshal()).thenReturn(mockRecord);
     when(mockPlatformClient.pushFileContainerContentToStreamSource(
             anyString(), any(FileContainer.class)))
@@ -53,21 +56,21 @@ public void uploadAndPushShouldExecute3StepWorkflowInOrder()
 
     InOrder inOrder = inOrder(mockPlatformClient);
     inOrder.verify(mockPlatformClient).createFileContainer();
-    inOrder.verify(mockPlatformClient)
+    inOrder
+        .verify(mockPlatformClient)
         .uploadContentToFileContainer(any(FileContainer.class), anyString());
-    inOrder.verify(mockPlatformClient)
+    inOrder
+        .verify(mockPlatformClient)
         .pushFileContainerContentToStreamSource(eq("test-source-id"), any(FileContainer.class));
     assertEquals(mockPushResponse, result);
   }
 
   @Test
-  public void uploadAndPushShouldReturnPushResponse()
-      throws IOException, InterruptedException {
+  public void uploadAndPushShouldReturnPushResponse() throws IOException, InterruptedException {
     when(mockContainerResponse.body()).thenReturn("{\"fileId\":\"test-id\"}");
     when(mockPlatformClient.createFileContainer()).thenReturn(mockContainerResponse);
     StreamUpdateRecord mockRecord =
-        new StreamUpdateRecord(
-            new JsonObject[] {}, new JsonObject[] {}, new JsonObject[] {});
+        new StreamUpdateRecord(new JsonObject[] {}, new JsonObject[] {}, new JsonObject[] {});
     when(mockStreamUpdate.marshal()).thenReturn(mockRecord);
     when(mockPlatformClient.pushFileContainerContentToStreamSource(
             anyString(), any(FileContainer.class)))
@@ -81,7 +84,8 @@ public void uploadAndPushShouldReturnPushResponse()
   @Test(expected = IOException.class)
   public void uploadAndPushShouldPropagateIOExceptionFromCreateFileContainer()
       throws IOException, InterruptedException {
-    when(mockPlatformClient.createFileContainer()).thenThrow(new IOException("Container creation failed"));
+    when(mockPlatformClient.createFileContainer())
+        .thenThrow(new IOException("Container creation failed"));
 
     handler.uploadAndPush(mockStreamUpdate);
   }
@@ -92,11 +96,9 @@ public void uploadAndPushShouldPropagateIOExceptionFromUploadContent()
     when(mockContainerResponse.body()).thenReturn("{\"fileId\":\"test-id\"}");
     when(mockPlatformClient.createFileContainer()).thenReturn(mockContainerResponse);
     StreamUpdateRecord mockRecord =
-        new StreamUpdateRecord(
-            new JsonObject[] {}, new JsonObject[] {}, new JsonObject[] {});
+        new StreamUpdateRecord(new JsonObject[] {}, new JsonObject[] {}, new JsonObject[] {});
     when(mockStreamUpdate.marshal()).thenReturn(mockRecord);
-    when(mockPlatformClient.uploadContentToFileContainer(
-            any(FileContainer.class), anyString()))
+    when(mockPlatformClient.uploadContentToFileContainer(any(FileContainer.class), anyString()))
         .thenThrow(new IOException("Upload failed"));
 
     handler.uploadAndPush(mockStreamUpdate);
@@ -108,8 +110,7 @@ public void uploadAndPushShouldPropagateIOExceptionFromPush()
     when(mockContainerResponse.body()).thenReturn("{\"fileId\":\"test-id\"}");
     when(mockPlatformClient.createFileContainer()).thenReturn(mockContainerResponse);
     StreamUpdateRecord mockRecord =
-        new StreamUpdateRecord(
-            new JsonObject[] {}, new JsonObject[] {}, new JsonObject[] {});
+        new StreamUpdateRecord(new JsonObject[] {}, new JsonObject[] {}, new JsonObject[] {});
     when(mockStreamUpdate.marshal()).thenReturn(mockRecord);
     when(mockPlatformClient.pushFileContainerContentToStreamSource(
             anyString(), any(FileContainer.class)))

src/test/java/com/coveo/pushapiclient/FileContainerRotationIntegrationTest.java

@@ -198,8 +198,7 @@ public void shouldNeverPushMultipleBatchesToSameContainer() throws Exception {
   }
 
   private UpdateStreamServiceInternal createServiceWithSmallBatchSize() {
-    CatalogStreamUploadHandler handler =
-        new CatalogStreamUploadHandler(source, platformClient);
+    CatalogStreamUploadHandler handler = new CatalogStreamUploadHandler(source, platformClient);
     StreamDocumentUploadQueue queue = new StreamDocumentUploadQueue(handler, SMALL_BATCH_SIZE);
     org.apache.logging.log4j.Logger logger =
         org.apache.logging.log4j.LogManager.getLogger(getClass());
@@ -231,12 +230,12 @@ private String generateData(int size) {
   private HttpResponse<String> createContainerResponse() {
     HttpResponse<String> response = mock(HttpResponse.class);
     int id = containerCounter.incrementAndGet();
-    doReturn(
-            String.format(
-                "{\"uploadUri\": \"https://upload.uri/container-%d\", \"fileId\": \"container-%d\"}",
-                id, id))
-        .when(response)
-        .body();
+    String responseBody =
+        String.format(
+            "{\"uploadUri\": \"https://upload.uri/container-%d\", "
+                + "\"fileId\": \"container-%d\"}",
+            id, id);
+    doReturn(responseBody).when(response).body();
     return response;
   }
 

src/test/java/com/coveo/pushapiclient/StreamDocumentUploadQueueTest.java

@@ -162,7 +162,7 @@ public void testShouldAutomaticallyFlushAccumulatedDocuments()
               }
             });
 
-     // Adding 3 documents of 2MB to the queue. After adding the first 2 documents,
+    // Adding 3 documents of 2MB to the queue. After adding the first 2 documents,
     // the queue size will reach 6MB, which exceeds the maximum queue size
     // limit by 1MB. Therefore, the 2 first added documents will automatically be
     // uploaded to the source.
@@ -236,7 +236,7 @@ public void testAddingEmptyDocument() throws IOException, InterruptedException {
 
     queue.add(nullDocument);
     queue.flush();
-    
+
     verify(mockHandler, times(0)).uploadAndPush(any(StreamUpdate.class));
   }
 

src/test/java/com/coveo/pushapiclient/UpdateStreamServiceInternalTest.java

@@ -1,8 +1,6 @@
 package com.coveo.pushapiclient;
 
 import static org.junit.Assert.assertEquals;
-import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
@@ -21,19 +19,13 @@
 public class UpdateStreamServiceInternalTest {
 
   private static final String SOURCE_ID = "my-source-id";
-  @Mock
-  private StreamEnabledSource source;
-  @Mock
-  private PlatformClient platformClient;
-  @Mock
-  private StreamDocumentUploadQueue queue;
-  @Mock
-  private HttpResponse<String> httpResponse;
-  @Mock
-  private Logger logger;
-
-  @InjectMocks
-  private UpdateStreamServiceInternal service;
+  @Mock private StreamEnabledSource source;
+  @Mock private PlatformClient platformClient;
+  @Mock private StreamDocumentUploadQueue queue;
+  @Mock private HttpResponse<String> httpResponse;
+  @Mock private Logger logger;
+
+  @InjectMocks private UpdateStreamServiceInternal service;
 
   private DocumentBuilder documentA;
   private DocumentBuilder documentB;
@@ -50,16 +42,18 @@ public void setUp() throws Exception {
     documentB = new DocumentBuilder("https://my.document.uri?ref=2", "My second document title");
     deleteDocumentA = new DeleteDocument("https://my.document.uri?ref=3");
     deleteDocumentB = new DeleteDocument("https://my.document.uri?ref=4");
-    partialUpdateDocumentA = new PartialUpdateDocument(
-        "https://my.document.uri?ref=5",
-        PartialUpdateOperator.FIELDVALUEREPLACE,
-        "fieldA",
-        "valueA");
-    partialUpdateDocumentB = new PartialUpdateDocument(
-        "https://my.document.uri?ref=6",
-        PartialUpdateOperator.FIELDVALUEREPLACE,
-        "fieldB",
-        "valueB");
+    partialUpdateDocumentA =
+        new PartialUpdateDocument(
+            "https://my.document.uri?ref=5",
+            PartialUpdateOperator.FIELDVALUEREPLACE,
+            "fieldA",
+            "valueA");
+    partialUpdateDocumentB =
+        new PartialUpdateDocument(
+            "https://my.document.uri?ref=6",
+            PartialUpdateOperator.FIELDVALUEREPLACE,
+            "fieldB",
+            "valueB");
 
     closeable = MockitoAnnotations.openMocks(this);