function can create Usages with the same metadata.name

[bobh66]

What happened?

When a Composition generates resources with the same metadata.name and kind but different API group/version - such as ProviderConfig.helm and ProviderConfig.kubernetes - the Usages created for these resources will have the same metadata.name because only the resource kind and metadata.name is included in the generated metadata.name, the API group/version is excluded and is the only differentiating factor. This results in a single Usage getting created but it toggles back and forth between the two resource dependencies on each subsequent reconciliation.

How can we reproduce it?

Using a composition that generates a ProviderConfig.helm and ProviderConfig.kubernetes which have the same metadata.name and are both sequenced to depend on another common resource.

Observe that there is a single generated Usage that gets recreated on every reconciliation and toggles back and forth between the two resources.

The function should leave the Usage name generation up to the kubernetes API server, and it should also leave the reason field blank so that the Usage controller can populate it automatically.

What environment did it happen in?

Function version: v0.5.0

[bobh66]

The problem is also present in the composition resource name (key) generation which is probably what causes the resources to flap. The key needs to be unique as well as the metadata.name