Cast short ints to uint8_t wherever necessary#95
Open
pwnage101 wants to merge 1 commit intocyborg5:masterfrom
Open
Cast short ints to uint8_t wherever necessary#95pwnage101 wants to merge 1 commit intocyborg5:masterfrom
pwnage101 wants to merge 1 commit intocyborg5:masterfrom
Conversation
Owner
|
The correct fix is to change uint8_t IR_PER_EorF; to int8_t IR_PER_EorF; in IRLibSAMD21.cpp at approximately line 30. I will fix it soon but I need to double check on something else first. |
kylefmohr
added a commit
to kylefmohr/IRLib2
that referenced
this pull request
Sep 18, 2021
found here: cyborg5#95
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, I couldn't compile with a SAMD21 chip because of the following error:
Not saying this is the correct way to fix the error, it's just how I solved it.
Minimal code example is based on one of the checked-in examples, and is what I used to test this PR: