From c5d684b74bed9d4a98cba3337890b068a43df2c7 Mon Sep 17 00:00:00 2001 From: dak2 Date: Sun, 15 Mar 2026 16:30:40 +0900 Subject: [PATCH] Fix release workflow to include gem assets in GitHub Release The previous approach of creating a GitHub Release directly in release-tag.yml caused two issues: 1. The release was created without gem files since no build step existed 2. GITHUB_TOKEN tag pushes do not trigger other workflows (GitHub Actions limitation), so release.yml never ran to build and attach gems Instead, release-tag.yml now explicitly triggers release.yml via workflow_dispatch after pushing the tag. This ensures gems are built and attached to the GitHub Release. Co-Authored-By: Claude Opus 4.6 (1M context) --- .github/workflows/release-tag.yml | 4 ++-- .github/workflows/release.yml | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release-tag.yml b/.github/workflows/release-tag.yml index daa616a..ea16d16 100644 --- a/.github/workflows/release-tag.yml +++ b/.github/workflows/release-tag.yml @@ -34,9 +34,9 @@ jobs: git tag "$TAG" git push origin "$TAG" - - name: Create GitHub Release + - name: Trigger release workflow env: TAG: ${{ steps.version.outputs.tag }} GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | - gh release create "$TAG" --generate-notes + gh workflow run release.yml --ref "$TAG" diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 0dfa1eb..97b591a 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -4,6 +4,7 @@ on: push: tags: - "v*" + workflow_dispatch: permissions: contents: write