解决ios10下因KVO引起的崩溃 issue #6

解决ios10下因KVO引起的崩溃 issue #6

Author: dengjianc

CollectionViewSideRefresh.xcodeproj/project.pbxproj

@@ -370,7 +370,7 @@
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CODE_SIGN_STYLE = Automatic;
-				DEVELOPMENT_TEAM = DTCHC66PTA;
+				DEVELOPMENT_TEAM = 4QA4S2484R;
 				INFOPLIST_FILE = CollectionViewSideRefresh/Info.plist;
 				IPHONEOS_DEPLOYMENT_TARGET = 9.0;
 				LD_RUNPATH_SEARCH_PATHS = (
@@ -388,7 +388,7 @@
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CODE_SIGN_STYLE = Automatic;
-				DEVELOPMENT_TEAM = DTCHC66PTA;
+				DEVELOPMENT_TEAM = 4QA4S2484R;
 				INFOPLIST_FILE = CollectionViewSideRefresh/Info.plist;
 				IPHONEOS_DEPLOYMENT_TARGET = 9.0;
 				LD_RUNPATH_SEARCH_PATHS = (

CollectionViewSideRefresh/SideRefresh/SideRefresh.m

@@ -13,14 +13,13 @@ @implementation SideRefresh
 
 - (void)willMoveToSuperview:(UIView *)newSuperview {
     [super willMoveToSuperview:newSuperview];
+    [self removeObserver];
     if ([newSuperview isKindOfClass:[UICollectionView class]]) {
         self.collectionView = (UICollectionView *)newSuperview;
         self.collectionView.alwaysBounceHorizontal = YES;
         self.originalContentInset = self.collectionView.side_inset;
         self.collectionViewPageEnabel = self.collectionView.pagingEnabled;
-        NSKeyValueObservingOptions options = NSKeyValueObservingOptionNew | NSKeyValueObservingOptionOld;
-        [self.collectionView addObserver:self forKeyPath:@"contentOffset" options:options context:nil];
-        [self.collectionView addObserver:self forKeyPath:@"contentSize" options:options context:nil];
+        [self addObserver];
     }
 }
 
@@ -38,9 +37,15 @@ - (void)endLoading {
     self.refreshStatus = SideRefreshStatusNormal;
 }
 
-- (void)dealloc {
-    [self.collectionView removeObserver:self forKeyPath:@"contentOffset"];
-    [self.collectionView removeObserver:self forKeyPath:@"contentSize"];
+- (void)removeObserver {
+    [self.superview removeObserver:self forKeyPath:@"contentOffset"];
+    [self.superview removeObserver:self forKeyPath:@"contentSize"];
+}
+
+- (void)addObserver {
+    NSKeyValueObservingOptions options = NSKeyValueObservingOptionNew | NSKeyValueObservingOptionOld;
+    [self.collectionView addObserver:self forKeyPath:@"contentOffset" options:options context:nil];
+    [self.collectionView addObserver:self forKeyPath:@"contentSize" options:options context:nil];
 }
 
 #pragma mark - ContentOffset Observer 

CollectionViewSideRefresh/SideRefresh/SideRefreshEmptyFooter.m

@@ -28,6 +28,7 @@ - (instancetype)initWithFrame:(CGRect)frame {
 
 - (void)willMoveToSuperview:(UIView *)newSuperview {
     [super willMoveToSuperview:newSuperview];
+    [self.superview removeObserver:self forKeyPath:@"contentSize"];
     if([newSuperview isKindOfClass:[UICollectionView class]]) {
         self.collectionView = (UICollectionView *)newSuperview;
         NSKeyValueObservingOptions options = NSKeyValueObservingOptionNew | NSKeyValueObservingOptionOld;
@@ -52,10 +53,6 @@ - (void)setupMessageLabel {
     [self addSubview:_messageLabel];
 }
 
-- (void)dealloc {
-    [self.collectionView removeObserver:self forKeyPath:@"contentSize"];
-}
-
 #pragma mark - ContentOffset Observer
 - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(NSDictionary<NSKeyValueChangeKey,id> *)change context:(void *)context {
     if([keyPath isEqualToString:@"contentSize"]) {

CollectionViewSideRefresh/SideRefreshDemo/CustomViewController.m

@@ -21,7 +21,7 @@ - (void)viewDidLoad {
     [super viewDidLoad];
     // Do any additional setup after loading the view, typically from a nib.
     self.title = @"自定义";
-    self.itemCount = 3;
+    self.itemCount = 0;
 
     UICollectionViewFlowLayout *flowLayout = [[UICollectionViewFlowLayout alloc] init];
     flowLayout.scrollDirection = UICollectionViewScrollDirectionHorizontal;
@@ -34,11 +34,15 @@ - (void)viewDidLoad {
 
     [self setupRefreshHeaderFoorer];
 }
+- (void)viewDidAppear:(BOOL)animated {
+    [super viewDidAppear:animated];
+    [self.collectionView.sideRefreshHeader beginLoading];
+}
 
 - (void)setupRefreshHeaderFoorer {
     __weak typeof(self) weakSelf = self;
     SideRefreshHeader *refreshHeader = [SideRefreshHeader refreshWithLoadAction:^{
-        dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(3 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{
+        dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(1 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{
             __strong __typeof(self) strongSelf = weakSelf;
             strongSelf.itemCount = 3;
             [strongSelf.collectionView.sideRefreshHeader endLoading];

CollectionViewSideRefresh/SideRefreshDemo/EmptyFooterViewController.m

@@ -22,7 +22,7 @@ - (void)viewDidLoad {
     [super viewDidLoad];
     // Do any additional setup after loading the view, typically from a nib.
     self.title = @"没有更多数据-提示";
-    self.itemCount = 3;
+    self.itemCount = 0;
 
     UICollectionViewFlowLayout *flowLayout = [[UICollectionViewFlowLayout alloc] init];
     flowLayout.scrollDirection = UICollectionViewScrollDirectionHorizontal;
@@ -37,10 +37,15 @@ - (void)viewDidLoad {
     [self setupRefreshHeaderFoorer];
 }
 
+- (void)viewDidAppear:(BOOL)animated {
+    [super viewDidAppear:animated];
+    [self.collectionView.sideRefreshHeader beginLoading];
+}
+
 - (void)setupRefreshHeaderFoorer {
     __weak typeof(self) weakSelf = self;
     SideRefreshHeader *refreshHeader = [SideRefreshHeader refreshWithLoadAction:^{
-        dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(3 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{
+        dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(1 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{
             __strong __typeof(self) strongSelf = weakSelf;
             strongSelf.itemCount = 3;
             [strongSelf.collectionView.sideRefreshHeader endLoading];

CollectionViewSideRefresh/SideRefreshDemo/HideItemViewController.m

@@ -22,7 +22,7 @@ - (void)viewDidLoad {
     [super viewDidLoad];
     // Do any additional setup after loading the view, typically from a nib.
     self.title = @"隐藏提示或动画";
-    self.itemCount = 3;
+    self.itemCount = 0;
 
     UICollectionViewFlowLayout *flowLayout = [[UICollectionViewFlowLayout alloc] init];
     flowLayout.scrollDirection = UICollectionViewScrollDirectionHorizontal;
@@ -37,10 +37,15 @@ - (void)viewDidLoad {
     [self setupRefreshHeaderFoorer];
 }
 
+- (void)viewDidAppear:(BOOL)animated {
+    [super viewDidAppear:animated];
+    [self.collectionView.sideRefreshHeader beginLoading];
+}
+
 - (void)setupRefreshHeaderFoorer {
     __weak typeof(self) weakSelf = self;
     SideRefreshHeader *refreshHeader = [SideRefreshHeader refreshWithLoadAction:^{
-        dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(3 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{
+        dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(1 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{
             __strong __typeof(self) strongSelf = weakSelf;
             strongSelf.itemCount = 3;
             [strongSelf.collectionView.sideRefreshHeader endLoading];