Battery Status

[mpk2]

BatteryStatus.java currently doesn't correctly return the battery status.

[mpk2]

I think both.
On Jul 22, 2015 11:30 AM, "Drazcmd" notifications@github.com wrote:

I can see it's hard coded as 100% for OS X (so obviously not implemented
yet) but there is code for both windows and linux; have you noticed if it's
actually broken on both windows and linux or just one of the two?

—
Reply to this email directly or view it on GitHub
#48 (comment).

[Drazcmd]

I'll take a look at this today, there's some existing (broken?) code for both linux and windows but osx is just hard-coded as 100%.

EDIT - didn't see your reply, thanks

[Drazcmd]

I've mad a quick, standalone test class as a proof of concept for getting the battery percentage on OS X, which works mostly along the same lines as the linux code already written. Hopefully the general idea should work just fine with Windows too, I assume the only difference will be the string passed into the command line and any necessary formatting of the returned output. I'm putting this here for now since I won't be ready to commit anything for a little while

public class testingCommandLineJavaFORMAC {

public static void main (String arg[]) {
    System.out.println("HELLO WORLD!");
    System.out.println(testWriteToCommandLine()); 
}

private static int testWriteToCommandLine() {

    try {
        //String cmd = "echo 94853";
        String cmd = "pmset -g batt | egrep '([0-9]+\\%).*' -o | cut -f1 -d';'";

        //Note that ProcessBuilder is not synchronized. If multiple threads access a ProcessBuilder instance
        //concurrently, and at least one of the threads modifies one of the attributes structurally, 
        //it must be synchronized externally

        ProcessBuilder pb = new ProcessBuilder("bash", "-c", cmd);

        pb.redirectErrorStream(true);
        Process child = pb.start();

        assert child.getInputStream().read() == -1;

        BufferedReader out = new BufferedReader(new InputStreamReader(child.getInputStream()));
        String s = out.readLine();

        if(s!=null){

            //s is currently a string that looks like '100%' or '43%' or '2%' etc. We want everything but the % character
            return Integer.parseInt(s.replace('%', ' ').trim());
        }

    } catch (Exception e) {
        System.out.println("Got an exception ->" + e);
        return -1;
    }
return -2;
}

}

[Drazcmd]

Installed windows 8.1 on my laptop today and did the same thing as with OSX, here it is:

public class testingCommandLineJavaFORWINDOWS {

public static void main (String arg[]) {
    System.out.println("HELLO WORLD!");
    System.out.println(testWriteToCommandLine()); 
}

private static int testWriteToCommandLine() {

    try {
        final List<String> cmd = new ArrayList<String>();
        cmd.add("WMIC");
        cmd.add("PATH");
        cmd.add("Win32_Battery"); 
        cmd.add("Get"); 
        cmd.add("EstimatedChargeRemaining");

        //Note that ProcessBuilder is not synchronized. If multiple threads access a ProcessBuilder instance
        //concurrently, and at least one of the threads modifies one of the attributes structurally, 
        //it must be synchronized externally
        ProcessBuilder pb = new ProcessBuilder(cmd);
        pb.redirectErrorStream(true);
        Process child = pb.start();

        assert child.getInputStream().read() == -1;

        BufferedReader out = new BufferedReader(new InputStreamReader(child.getInputStream()));

        //The battery percentage will be the third line outputted (just the integer, no percent sign)
        String s = out.readLine();
        s = out.readLine();
        s = out.readLine();
        return Integer.valueOf(s.trim());

    } catch (Exception e) {
        System.out.println("Got an exception ->" + e);
        return -1;
    }
}
}

I'll see if I can get Linux taken care of today or tomorrow

[umbernhard]

In the fix for mac, is it a good idea to replace %'s with \0? In the incredibly unlikely chance that it isn't at the end of the string, this could be really bad. Why not just an empty string?

[Drazcmd]

Oops, my bad haha. Yes,

    return Integer.parseInt(s.replace('%', ' ').trim());

would definitely be a better choice than

   return Integer.parseInt(s.replace('%', '\0').trim());

I've gone and made the change (to my own test version, no commits yet). Thanks

[mpk2]

Make sure you pull the master to debug before you commit to debug... I
think the master may be a commit or two ahead.

On Thu, Jul 23, 2015 at 3:45 PM, Matthew Bernhard notifications@github.com
wrote:

In the fix for mac, is it a good idea to replace %'s with \0? In the
incredibly unlikely chance that it isn't at the end of the string, this
could be really bad. Why not just an empty string?

—
Reply to this email directly or view it on GitHub
#48 (comment).

[mpk2]

@Drazcmd curious if this is done and I can close it