Context
Surfaced by CodeRabbit during review of #711. Pre-existing behavior — #711 is a structural-only split and moves this code unchanged.
Problem
ManagedCoreFundsAccount::confirm_transaction is documented to handle "potentially new address matches from gap limit rescans," but for an already-recorded transaction it only updates context and runs update_utxos. The derived fields on the stored TransactionRecord — net_amount, direction, and the per-input/output role flags — are computed once at record_transaction time and never refreshed.
Consequence: a transaction that was first recorded with a partial account_match (e.g. before a gap-limit rescan widened the matching address set) will keep stale wallet metadata even after the rescan re-confirms it.
Suggested fix
When confirm_transaction sees an existing record and the incoming account_match differs from what was used the first time, recompute the derived metadata (re-running the same logic as record_transaction or replacing the entry while preserving transaction_type and context), then continue with the UTXO update.
Files
key-wallet/src/managed_account/managed_core_funds_account.rs (confirm_transaction, record_transaction)
Original review thread: #711 (review comment 3178371385)
Context
Surfaced by CodeRabbit during review of #711. Pre-existing behavior — #711 is a structural-only split and moves this code unchanged.
Problem
ManagedCoreFundsAccount::confirm_transactionis documented to handle "potentially new address matches from gap limit rescans," but for an already-recorded transaction it only updatescontextand runsupdate_utxos. The derived fields on the storedTransactionRecord—net_amount,direction, and the per-input/output role flags — are computed once atrecord_transactiontime and never refreshed.Consequence: a transaction that was first recorded with a partial
account_match(e.g. before a gap-limit rescan widened the matching address set) will keep stale wallet metadata even after the rescan re-confirms it.Suggested fix
When
confirm_transactionsees an existing record and the incomingaccount_matchdiffers from what was used the first time, recompute the derived metadata (re-running the same logic asrecord_transactionor replacing the entry while preservingtransaction_typeandcontext), then continue with the UTXO update.Files
key-wallet/src/managed_account/managed_core_funds_account.rs(confirm_transaction,record_transaction)Original review thread: #711 (review comment 3178371385)