manage_metric_views: comment field ordering causes METRIC_VIEW_INVALID_VIEW_DEFINITION

[shuji-db]

Bug Description

When using manage_metric_views with the create action and a comment field, the generated YAML places comment before source, causing a parse error:

METRIC_VIEW_INVALID_VIEW_DEFINITION: Missing required creator property 'source' (index 1)

Steps to Reproduce

Use manage_metric_views with create action including a comment field.

Actual Behavior

Generated YAML has incorrect field ordering:

version: 1.1
comment: "..."
source: catalog.schema.table

The parser expects source as the 2nd field (index 1), but comment appears there instead.

Expected Behavior

version: 1.1
source: catalog.schema.table
comment: "..."

Workaround

Using execute_sql with raw YAML (manually specifying correct field order) works as expected.

[shuji-db]

Investigation

The root cause is in _build_yaml_block() at databricks-tools-core/databricks_tools_core/unity_catalog/metric_views.py (lines 45-50):

lines = [f"version: {version}"]

if comment:
    lines.append(f'comment: "{comment}"')

lines.append(f"source: {source}")

This generates version → comment → source, but the Databricks API expects source at index 1 (i.e. version → source → comment).

The documentation (SKILL.md, patterns.md) and test data (ground_truth.yaml) also use the same incorrect ordering, so all three need to be updated.

Fix

Swap comment and source in:

1. databricks-tools-core/databricks_tools_core/unity_catalog/metric_views.py
2. databricks-skills/databricks-metric-views/SKILL.md
3. databricks-skills/databricks-metric-views/patterns.md
4. .test/skills/databricks-metric-views/ground_truth.yaml