refactor: replace fragmented theme system with unified ThemeEngine#320
Merged
refactor: replace fragmented theme system with unified ThemeEngine#320
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis PR centralizes theming into ThemeEngine: removes legacy theme/token files, adds color/hex utilities and theme UI, migrates 40+ views to ThemeEngine.shared for fonts, colors, spacing and icon sizes, introduces a themeDidChange notification and DataGridView theme observer, and removes per-window accent tinting. Changes
Sequence Diagram(s)sequenceDiagram
participant User as User/UI
participant ThemeEditor as ThemeEditorFontsSection
participant ThemeEngine as ThemeEngine.shared
participant Notification as NotificationCenter
participant View as DataGridView / Other Views
User->>ThemeEditor: change font/color and save
ThemeEditor->>ThemeEngine: update active theme
ThemeEngine->>Notification: post themeDidChange
Notification->>View: receives themeDidChange
View->>ThemeEngine: read new fonts/colors
View->>View: apply visual updates (fonts, spacing, colors)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Theme.swift,DesignConstants.swift,SQLEditorTheme.swift,ToolbarDesignTokens.swift,DataGridFontCache.swift) with the unifiedThemeEnginesingletonTheme.*,DesignConstants.*,SQLEditorTheme.*references toThemeEngine.shared.colors.*/ThemeEngine.shared.activeTheme.*HexColor.swift(hex string to NSColor/Color conversion) andResolvedThemeColors.swift(pre-resolved NSColor cache from theme hex strings)ThemePreviewCard.swift(visual thumbnail for theme list) andThemeEditorFontsSection.swift(font picker with live preview)Deleted files
Theme.swift— old static color constantsDesignConstants.swift— old spacing/sizing constantsSQLEditorTheme.swift— old editor color constantsToolbarDesignTokens.swift— old toolbar styling constantsDataGridFontCache.swift— moved intoThemeEngineasDataGridFontCacheResolvedTest plan
Theme.*/DesignConstants.*patterns)Summary by CodeRabbit
New Features
Changes