Skip to content

Commit baa67fa

Browse files
authored
Merge pull request #1816 from dbcli/RW/do-not-log-ssh-passwords
Avoid logging SSH passwords
2 parents bec53b9 + c843c78 commit baa67fa

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ Bug Fixes
1919
* Make multi-line detection and special cases more robust.
2020
* Run empty `--execute` arguments instead of ignoring the flag.
2121
* Exit with error when the `--batch` argument is an empty string.
22+
* Avoid logging SSH passwords.
2223

2324

2425
Internal

mycli/sqlexecute.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ def connect(
245245
"\tssh_user: %r"
246246
"\tssh_host: %r"
247247
"\tssh_port: %r"
248-
"\tssh_password: %r"
248+
"\tssh_password: ***"
249249
"\tssh_key_filename: %r"
250250
"\tinit_command: %r"
251251
"\tunbuffered: %r",
@@ -260,7 +260,6 @@ def connect(
260260
ssh_user,
261261
ssh_host,
262262
ssh_port,
263-
ssh_password,
264263
ssh_key_filename,
265264
init_command,
266265
unbuffered,

0 commit comments

Comments
 (0)