PR 176 on master?

[iagogv3]

Hi Dominic,

First of all, I've just seen you are working in the package again and you have updated the release version recently. Many thanks for that.

Checking the development version I had installed against the released version, I found that the PR #176, which had been merged, is not present in the release, and looking at it I've just seen that the merge was not on master, but in other branch.

Would it be worth merging it to master or you prefer don't do it?

Thanks again!

[dcomtois]

Thanks for the feedback. I remember I put it aside b/c with the formula syntax, we can't get contextual help (pressing tab didn't show parameters/documentation in RStudio). I'd need to check if this is still the case, and if so, an option would be to create a wrapper function that works with formulas (ctablef for instance), leaving the original as is. I'm open to other ideas!

[iagogv3]

@dcomtois Thanks for answering. That I know, that was the issue with PR #174 (#174 (comment)), which was avoid by #176. I do not know if there is some other issue, but you may check...

[dcomtois]

Thanks for refreshing my memory! After merging in a local branch and running a few tests, I just recalled... The formulae work fine, but there would need to be adjustments made in the parse_call function, or maybe I'll add a condition to bypass it altogether when a formula is used. On my todo list now.

[dcomtois]

It turns out it's more complicated than I expected. The necessary adjustments -- making ctable() generic, in particular, and having to account for less typical uses, like using a formula for vectors in the global env, using indices in formulas, etc.) -- tend to break other functionalities, especially with the parse_call() function. Bypassing it for the formula method doesn't really help. A more robust name-finding algorithm will require some in-depth work. Not giving up just yet, but it will take a while.