Non-executable code present on the flutter_dropzone.js

[Lufan]

file: flutter_dropzone_web/lib/assets/flutter_dropzone.js

Part of code that never happens to be executed as clause 'if (event.dataTransfer.items)' always resolve to true:

async drop_handler(event) {
  if (event.dataTransfer.items) {

  } else {
-->      for (var i = 0; i < ev.dataTransfer.files.length; i++)
-->        var file = event.dataTransfer.files[i];
-->        if (this.onDrop != null) this.onDrop(event, file);
-->        if (this.onDropFile != null) this.onDropFile(event, file);
-->        files.push(file);
  }
}

it never executed and have issue with using ev.dataTransfer.files.length instead of event.dataTransfer.files.length

[deakjahn]

this code never works as it have errors.

That's certainly fair enough and a good catch, so let's start with this.

I probably used some sample on the web that probably suggested the extra condition in the first place. Maybe IE back in the day was stupid enough to not follow the docs, I really don't know. We could replace the else branch with a deprecation warning, for instance, but I'd still think the if sanity check is still viable, it doesn't make any difference then.

[deakjahn]

Could you check this now, with the latest? Still there in comments, who knows what happens.

[deakjahn]

I forgot your let and const changes, I'll upload those shortly, too.

[Lufan]

Hi deakjahn!. Looks good (still some var declarations there - and good to use const if possible but this is not an errors).
Thanks for your patience. Bye.