Skip to content

[Snyk] Security upgrade idna from 2.10 to 3.7 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deargvp1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade idna from 2.10 to 3.7 #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions composer/airflow_1_samples/requirements-test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
pytest==8.2.0
cloud-composer-dag-test-utils==0.0.1
idna>=3.7 # not directly required, pinned by Snyk to avoid a vulnerability
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change introduces a dependency conflict. The project uses apache-airflow 1.10.15, which depends on requests 2.23.0. As highlighted in the PR description, requests 2.23.0 requires idna<3,>=2.5. Pinning idna>=3.7 will cause installation failures during dependency resolution because the constraints are mutually exclusive.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: The idna>=3.7 pin conflicts with the existing idna==2.8 constraint (from constraints.txt) required by requests==2.23.0 used by apache-airflow==1.10.15. Installing these test requirements together with the Airflow 1.10.x dependencies will either fail pip resolution or break the requests dependency chain, causing import errors at test time.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At composer/airflow_1_samples/requirements-test.txt, line 3:

<comment>The `idna>=3.7` pin conflicts with the existing `idna==2.8` constraint (from `constraints.txt`) required by `requests==2.23.0` used by `apache-airflow==1.10.15`. Installing these test requirements together with the Airflow 1.10.x dependencies will either fail pip resolution or break the `requests` dependency chain, causing import errors at test time.</comment>

<file context>
@@ -1,2 +1,3 @@
 pytest==8.2.0
 cloud-composer-dag-test-utils==0.0.1
+idna>=3.7 # not directly required, pinned by Snyk to avoid a vulnerability
</file context>