feat: add support to more postgres types issue#102 by dev-void-7 · Pull Request #105 · TabularisDB/tabularis

dev-void-7 · 2026-03-25T21:43:53Z

Supported Postgres Types

Limitation With `sqlx`

I think it is not possible to implement Nested composite types, Array of composite type or Nested arrays because sqlx does not expose (does not make the public outside of the crate) important functions and methods to do that

Code Review Summary

Status: 4 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	2
WARNING	0
SUGGESTION	2

Issue Details (click to expand)

CRITICAL

File	Line	Issue
`extract/array.rs`	34	Incorrect buffer length check - check `buf.len() * dimentions < 8 * dimentions` is algebraically equivalent to `buf.len() < 8` but should ensure `buf.len() >= 12 + 8 * dimensions`
`extract/common.rs`	11	Missing bounds check before `buf[..4]` - will panic if buffer has fewer than 4 bytes

SUGGESTION

File	Line	Issue
`extract/array.rs`	17	Typo: `dimentions` should be `dimensions` (also appears on lines 20, 26, 31, 34, 61, 87)
`extract/composite.rs`	9	Typo: `recieved` should be `received`

Notes on Previous Review

The previous review comments regarding DateTime<Local> and i8 array handling (on the deleted extract.rs file) are now obsolete. The file has been replaced with a new module structure using tokio-postgres. The new implementation:

Uses a different architecture with separate modules for simple, array, and composite types
No longer handles DateTime<Local> (only DateTime<Utc> for TIMESTAMPTZ)
Handles nested arrays and composite types through recursive extraction

Files Reviewed (6 files)

src-tauri/src/drivers/postgres/extract/array.rs - New array extraction logic with buffer parsing bugs
src-tauri/src/drivers/postgres/extract/common.rs - Missing bounds check on buffer operations
src-tauri/src/drivers/postgres/extract/composite.rs - Typo in error message
src-tauri/src/drivers/postgres/extract/mod.rs - Main extraction module implementing FromSql
src-tauri/src/drivers/postgres/extract/simple.rs - Simple type extraction (no issues found)
src-tauri/src/drivers/postgres/mod.rs - Updated driver using tokio-postgres (no issues found)
src-tauri/src/pool_manager.rs - Updated pool manager with deadpool-postgres (no issues found)

_{Reviewed by kimi-k2.5-0127 · 555,131 tokens}

debba · 2026-03-25T22:08:56Z

Yes looks ok to me , you can go ahead

debba · 2026-03-26T10:28:53Z

@dev-void-7 I will wait you complete tasks related for doing a review, let me know when is ready thanks

dev-void-7 · 2026-03-26T12:47:17Z

Hi,
It will take some time because sqlx (postgres related logic) is used in more than one place.
I'll let you know as soon as I'm finished.

My regards

…keyword

…odify `macro` to align with `tokio-postgres::Row` too

…ule to `extact`

kilo-code-bot · 2026-03-27T20:22:47Z

+    let dimentions = dimentions as usize;
+
+    // each dimension must have at least 8 bytes info
+    if buf.len() * dimentions < 8 * dimentions {


CRITICAL: Incorrect buffer length check logic

The check buf.len() * dimentions < 8 * dimentions is algebraically equivalent to buf.len() < 8 (assuming dimensions > 0), which is incorrect.

At this point, buf still contains the 12-byte header. The check should ensure there are 8 * dimensions bytes remaining AFTER the header for dimension descriptors.

Suggested change

if buf.len() * dimentions < 8 * dimentions {

if buf.len() < 12 + 8 * dimentions {

kilo-code-bot · 2026-03-27T20:22:47Z

+}
+
+pub fn split_at_value_len<'a>(buf: &mut &'a [u8]) -> Result<&'a [u8], ()> {
+    let len = i32::from_be_bytes(match buf[..4].try_into() {


CRITICAL: Missing bounds check before slicing

This will panic if buf has fewer than 4 bytes. Should check buf.len() < 4 first.

Suggested change

let len = i32::from_be_bytes(match buf[..4].try_into() {

if buf.len() < 4 {

log::error!("Buffer too short: {}", buf.len());

return Err(());

}

let len = i32::from_be_bytes(match buf[..4].try_into() {

Ok(bytes) => bytes,

Err(e) => {

log::error!("Failed to parse value length: {:?}", e);

return Err(());

}

});

no need to check because try_into will not panic, but will return Result instead,, in addition to the fact that Result is checked.

kilo-code-bot · 2026-03-27T20:22:47Z

+        return Err(());
+    };
+
+    let dimentions = i32::from_be_bytes(buf[..4].try_into().unwrap());


SUGGESTION: Typo in variable name

dimentions should be dimensions. This typo appears throughout the file (lines 17, 20, 26, 31, 34, 61, 87).

Suggested change

let dimentions = i32::from_be_bytes(buf[..4].try_into().unwrap());

let dimensions = i32::from_be_bytes(buf[..4].try_into().unwrap());

kilo-code-bot · 2026-03-27T20:22:48Z

+#[inline]
+pub fn extract_or_null(fields: &Vec<Field>, buf: &mut &[u8]) -> Result<JsonValue, ()> {
+    if buf.len() == 0 {
+        log::error!("recieved empty buffer");


SUGGESTION: Typo in error message

recieved should be received.

Suggested change

log::error!("recieved empty buffer");

log::error!("received empty buffer");

dev-void-7 · 2026-03-27T20:39:57Z

@debba hi,
i made some tests to the software on my laptop and it can be said that there are no problems now with Nested Arrays, Composite types and Composite[] 🎉.
i have some notes:

rustfmt breaked some lines into multiple lines (i don't know why. i use the default configuration) and tried to fix that but couldn't.
i modified two macro_rules so that they align with tokio-postgres too.
i made some unit tests for Array type extraction only.

inform me if there is any problem in the code.
Thank You very much in advance for your hard work and for this very amazing project.

My Regards

debba · 2026-03-28T06:59:00Z

Hi @dev-void-7 ,
thanks a lot for your work.

I tried to do some tests with array columns but always have: Error: db error

dev-void-7 · 2026-03-28T11:34:06Z

@debba
i will check that as soon as possible.
I think this is related to the change from sqlx to tokio_postgres.

dev-void-7 · 2026-03-28T12:41:54Z

@debba
hi,

there is a syntax error with the query
INSERT test_null_arr (arr_col) VALUES (ARRAY[]::INT[], ARRAY[1]::INT[])
the correct query is:
INSERT test_null_arr (arr_col) VALUES (ARRAY[]::INT[]), (ARRAY[1]::INT[])

anyway this is related to the error message being unclear at all.

i tried to fix this like that:

what do you think?

debba · 2026-03-28T12:46:56Z

Yes looks great, it could be wonderful to have the message and a button for viewing full details what do you think?

dev-void-7 · 2026-03-28T13:00:13Z

i think to implement this we should return a struct instead of String for error messages with two fields summary and details. if the use wants the details he/she can click a button to display them otherwise a summary will be shown.

anyway if we want to do that i think it should be in a separate PR. do you agree?

i am going to push the commits i made so you can test things 😊. Thank you in advance

debba · 2026-03-28T14:44:42Z

Thanks, I will merge it :)

dev-void-7 · 2026-03-28T15:03:30Z

Thank You very much this was my first PR 😊🎉🔥. I hope my contribution was helpful

There is still some types that is not supported like enums and ranges. once i finish them i will open another PR

My Regards

debba · 2026-03-28T15:07:34Z

The thanks go entirely to you; I’ll create a release between today and tomorrow.
I hope you’ll continue collaborating, t’s really helpful to have talented people like you.
If you’d like, share the project; the more it grows, the more we’ll be able to solve a lot of things in a short time.

dev-void-7 · 2026-03-28T15:16:27Z

For sure i will continue collaborating specifically on Postgres part

have a nice day 🔥.

debba · 2026-03-29T09:52:33Z

I added my thanks here:

https://tabularis.dev/blog/v0912-tokio-postgres-minimax-json-editor

add support to more postgres types

0e8fac6

kilo-code-bot bot reviewed Mar 25, 2026

View reviewed changes

Comment thread src-tauri/src/drivers/postgres/extract.rs Outdated

Comment thread src-tauri/src/drivers/postgres/extract.rs Outdated

dev-void-7 added 2 commits March 25, 2026 23:51

fix: add missing extracting logic

743b655

fix: add missing extracting logic

6c1bcc2

dev-void-7 changed the title ~~feat: add support to more postgres types #102~~ feat: add support to more postgres types issue#102 Mar 25, 2026

dev-void-7 added 13 commits March 26, 2026 19:26

add crates and features needed to migrate to tokio-postgres

c94c8f1

add extraction logic of tokio-postgres::Row to JsonValue

7485f66

add tests for array extraction

8dc9e24

replace sqlx postgres pool with tokio-postgres pool

044725a

add crates to enable Tls for postgres

a457fe5

replace all sqlx postgres related logic with tokio-postgres

9d67d63

replace all sqlx postgres related logic with tokio-postgres

719c6a7

fix query_raw type annotations needed issue

9b0fb23

fix query_raw type annotations needed issue and add fogotten mut …

34de7de

…keyword

replace all sqlx postgres related logic with tokio-postgres and m…

31b05cc

…odify `macro` to align with `tokio-postgres::Row` too

remove extract sqlx module and rename extract2 tokio-postgres mod…

892e114

…ule to `extact`

add advance_buf function

17d4448

fix: skip the field type bytes

3d4401c

kilo-code-bot bot reviewed Mar 27, 2026

View reviewed changes

fix issues mentioned by kilo-code-bot

72db66a

dev-void-7 and others added 2 commits March 28, 2026 15:01

improve error messages

56e694f

Merge branch 'main' into feat/support-more-pg-types

ffcfbdb

debba merged commit 13c733b into TabularisDB:main Mar 28, 2026

dev-void-7 deleted the feat/support-more-pg-types branch March 29, 2026 11:10

	if buf.len() * dimentions < 8 * dimentions {
	if buf.len() < 12 + 8 * dimentions {

-    let len = i32::from_be_bytes(match buf[..4].try_into() {
+    if buf.len() < 4 {
+        log::error!("Buffer too short: {}", buf.len());
+        return Err(());
+    }
+    let len = i32::from_be_bytes(match buf[..4].try_into() {
+        Ok(bytes) => bytes,
+        Err(e) => {
+            log::error!("Failed to parse value length: {:?}", e);
+            return Err(());
+        }
+    });

	let dimentions = i32::from_be_bytes(buf[..4].try_into().unwrap());
	let dimensions = i32::from_be_bytes(buf[..4].try_into().unwrap());

	log::error!("recieved empty buffer");
	log::error!("received empty buffer");

Uh oh!

Conversation

dev-void-7 commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Supported Postgres Types

Limitation With sqlx

Suggested Solution

Uh oh!

Uh oh!

Uh oh!

kilo-code-bot bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

Overview

CRITICAL

SUGGESTION

Uh oh!

debba commented Mar 25, 2026

Uh oh!

debba commented Mar 26, 2026

Uh oh!

dev-void-7 commented Mar 26, 2026

Uh oh!

kilo-code-bot bot Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot bot Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

dev-void-7 Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot bot Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot bot Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

dev-void-7 commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

debba commented Mar 28, 2026

Uh oh!

dev-void-7 commented Mar 28, 2026

Uh oh!

dev-void-7 commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

debba commented Mar 28, 2026

Uh oh!

dev-void-7 commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

debba commented Mar 28, 2026

Uh oh!

dev-void-7 commented Mar 28, 2026

Uh oh!

debba commented Mar 28, 2026

Uh oh!

dev-void-7 commented Mar 28, 2026

Uh oh!

debba commented Mar 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dev-void-7 commented Mar 25, 2026 •

edited

Loading

Limitation With `sqlx`

kilo-code-bot bot commented Mar 25, 2026 •

edited

Loading

dev-void-7 commented Mar 27, 2026 •

edited

Loading

dev-void-7 commented Mar 28, 2026 •

edited

Loading

dev-void-7 commented Mar 28, 2026 •

edited

Loading