From 57b247775277e5913c26d41ea152b6896077c055 Mon Sep 17 00:00:00 2001 From: bahtya Date: Sat, 4 Apr 2026 18:12:33 +0800 Subject: [PATCH] Fix infinite loop in 'gh release list --limit 0' Other list subcommands correctly reject --limit 0 but 'release list' does not validate the limit, causing an infinite loop. Add validation consistent with other subcommands and a test. Closes #13078 --- pkg/cmd/release/list/list.go | 4 ++++ pkg/cmd/release/list/list_test.go | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/pkg/cmd/release/list/list.go b/pkg/cmd/release/list/list.go index 8971005629a..28e8c93a0db 100644 --- a/pkg/cmd/release/list/list.go +++ b/pkg/cmd/release/list/list.go @@ -44,6 +44,10 @@ func NewCmdList(f *cmdutil.Factory, runF func(*ListOptions) error) *cobra.Comman // support `-R, --repo` override opts.BaseRepo = f.BaseRepo + if opts.LimitResults < 1 { + return cmdutil.FlagErrorf("invalid limit: %v", opts.LimitResults) + } + if runF != nil { return runF(opts) } diff --git a/pkg/cmd/release/list/list_test.go b/pkg/cmd/release/list/list_test.go index e1eb6ca32ef..c29161d9d7a 100644 --- a/pkg/cmd/release/list/list_test.go +++ b/pkg/cmd/release/list/list_test.go @@ -58,6 +58,11 @@ func Test_NewCmdList(t *testing.T) { Order: "desc", }, }, + { + name: "zero limit", + args: "--limit 0", + wantErr: "invalid limit: 0", + }, { name: "with order", args: "--order asc",