diff --git a/pkg/codegen/cgen_test.go b/pkg/codegen/cgen_test.go index 33ef878..8f15e07 100644 --- a/pkg/codegen/cgen_test.go +++ b/pkg/codegen/cgen_test.go @@ -2377,9 +2377,7 @@ let v = m["a"]; t.Fatalf("parser errors: %v", p.Errors()) } checker := types.NewChecker() - if !checker.Check(program) { - // type checker may not fully resolve this - use output anyway - } + checker.Check(program) gen := NewCGenerator() gen.SetTypeInfo(checker.TypeInfo()) output := gen.Generate(program) diff --git a/pkg/module/module_test.go b/pkg/module/module_test.go index aa81133..d8565b7 100644 --- a/pkg/module/module_test.go +++ b/pkg/module/module_test.go @@ -1,6 +1,7 @@ package module import ( + "errors" "os" "path/filepath" "testing" @@ -891,7 +892,8 @@ func TestLoaderLoadParseError(t *testing.T) { if err == nil { t.Error("expected parse error") } - if _, ok := err.(*ParseError); !ok { + var parseErr *ParseError + if !errors.As(err, &parseErr) { t.Errorf("expected *ParseError, got %T", err) } } @@ -1029,7 +1031,10 @@ func TestFindProjectRootFromConfigDir(t *testing.T) { t.Fatalf("FindProjectRoot error: %v", err) } - absDir, _ := filepath.Abs(tmpDir) + absDir, err := filepath.Abs(tmpDir) + if err != nil { + t.Fatalf("filepath.Abs error: %v", err) + } if root != absDir { t.Errorf("expected %q, got %q", absDir, root) }