Remove extraArgs from admissionController when VPA supports InPlaceOrRecreate by default...

[github-actions]

platform/k8s/bases/infrastructure/controllers/goldilocks/helm-release.yaml

Line 57 in 49381e3

# TODO: Remove extraArgs from admissionController when VPA supports InPlaceOrRecreate by default

              name: goldilocks-vpa-admission-controller
            patch: |
              - op: remove
                path: /spec/template/spec/containers/0/args/0
              - op: remove
                path: /spec/template/spec/containers/0/args/0
  # https://github.com/FairwindsOps/charts/blob/master/stable/goldilocks/values.yaml
  values:
    # https://github.com/FairwindsOps/charts/blob/master/stable/vpa/values.yaml
    vpa:
      enabled: true
      # TODO: Remove recommender image configuration when Goldilocks is updated to use VPA 1.4.0
      recommender:
        image:
          repository: registry.k8s.io/autoscaling/vpa-recommender
          tag: 1.4.0
      # TODO: Remove updater image configuration when Goldilocks is updated to use VPA 1.4.0
      updater:
        enabled: true
        image:
          repository: registry.k8s.io/autoscaling/vpa-updater
          tag: 1.4.0
        # TODO: Remove extraArgs from updater when VPA supports InPlaceOrRecreate by default
        extraArgs:
          feature-gates: InPlaceOrRecreate=true
      # TODO: Remove admissionController image configuration when Goldilocks is updated to use VPA 1.4.0
      admissionController:
        # fix to remove unsupported tls args from admission controller
        generateCertificate: false
        image:
          repository: registry.k8s.io/autoscaling/vpa-updater
          tag: 1.4.0
        # TODO: Remove extraArgs from admissionController when VPA supports InPlaceOrRecreate by default
        extraArgs:
          feature-gates: InPlaceOrRecreate=true
    controller:

[devantler]

InPlaceOrRecreate feature gates have been re-enabled in the standalone VPA helm-release for both updater and admissionController components.

InPlaceOrRecreate is currently alpha in VPA 1.4.x, beta in 1.5.0, and GA in 1.6.0. Once the VPA chart is updated to appVersion 1.6.0+, the feature gates can be removed and this issue can be closed.

Keeping this issue open until then.