Skip to content

Commit 23815ea

Browse files
committed
fix: enhance validation for session limit and optimize error handling logic
1 parent 8a57990 commit 23815ea

2 files changed

Lines changed: 4 additions & 11 deletions

File tree

endpoints/sessions.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const addSystemMessageBodySchema = z.object({
1010
}).strict();
1111

1212
const getSessionsBodySchema = z.object({
13-
limit: z.number().optional(),
13+
limit: z.number().int().min(1).max(100).optional(),
1414
}).strict();
1515

1616
const sessionIdBodySchema = z.object({
@@ -140,9 +140,7 @@ export function setupSessionEndpoints(ctx: SessionEndpointsContext, server: IHtt
140140
const turns = await ctx.adminforth.resource(ctx.options.turnResource.resourceId).list(
141141
[Filters.EQ(ctx.options.turnResource.sessionIdField, sessionId)]
142142
);
143-
for (const turn of turns) {
144-
await ctx.adminforth.resource(ctx.options.turnResource.resourceId).delete(turn[ctx.options.turnResource.idField]);
145-
}
143+
await Promise.all(turns.map(turn => ctx.adminforth.resource(ctx.options.turnResource.resourceId).delete(turn[ctx.options.turnResource.idField])));
146144
return {
147145
ok: true
148146
};
@@ -168,7 +166,6 @@ export function setupSessionEndpoints(ctx: SessionEndpointsContext, server: IHtt
168166
error: 'Unauthorized'
169167
};
170168
}
171-
await ctx.createNewTurn(data.sessionId, data.systemMessage);
172169
return {
173170
ok: true
174171
}

errors.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,8 @@
11
export function isAbortError(error: unknown): boolean {
2-
return (
3-
error instanceof DOMException && error.name === "AbortError"
4-
) || (
5-
typeof error === "object" &&
2+
return typeof error === "object" &&
63
error !== null &&
74
"name" in error &&
8-
(error.name === "AbortError" || error.name === "APIUserAbortError")
9-
);
5+
(error.name === "AbortError" || error.name === "APIUserAbortError");
106
}
117

128
export function getErrorMessage(error: unknown): string {

0 commit comments

Comments
 (0)