From cd043fb4e0b8d25e6c2125ca3e6710c66f4f14b0 Mon Sep 17 00:00:00 2001 From: rvasikarla Date: Sat, 4 Apr 2026 22:17:09 -0500 Subject: [PATCH] fix: prevent nil map panic when docker-compose.yaml has top-level name field When a docker-compose.yaml includes a top-level 'name:' field, the compose-go loader attempts to assign to ConfigDetails.Environment which is nil, causing a panic. Initialize the Environment map to an empty map before calling the loader. Fixes #2970 --- pkg/devspace/compose/manager.go | 1 + .../compose/testdata/named_project/devspace.yaml | 9 +++++++++ .../compose/testdata/named_project/docker-compose.yaml | 4 ++++ 3 files changed, 14 insertions(+) create mode 100644 pkg/devspace/compose/testdata/named_project/devspace.yaml create mode 100644 pkg/devspace/compose/testdata/named_project/docker-compose.yaml diff --git a/pkg/devspace/compose/manager.go b/pkg/devspace/compose/manager.go index 1e3ea4cf3f..6b48a5d8b5 100644 --- a/pkg/devspace/compose/manager.go +++ b/pkg/devspace/compose/manager.go @@ -44,6 +44,7 @@ func LoadDockerComposeProject(path string) (*composetypes.Project, error) { Content: composeFile, }, }, + Environment: map[string]string{}, }) if err != nil { return nil, err diff --git a/pkg/devspace/compose/testdata/named_project/devspace.yaml b/pkg/devspace/compose/testdata/named_project/devspace.yaml new file mode 100644 index 0000000000..ef39aecfd8 --- /dev/null +++ b/pkg/devspace/compose/testdata/named_project/devspace.yaml @@ -0,0 +1,9 @@ +version: v2beta1 +name: docker-compose +deployments: + web: + helm: + values: + containers: + - name: web-container + image: nginx:latest diff --git a/pkg/devspace/compose/testdata/named_project/docker-compose.yaml b/pkg/devspace/compose/testdata/named_project/docker-compose.yaml new file mode 100644 index 0000000000..f6e8be8628 --- /dev/null +++ b/pkg/devspace/compose/testdata/named_project/docker-compose.yaml @@ -0,0 +1,4 @@ +name: myproject +services: + web: + image: nginx:latest