Validation: skip static properties in generated model traversal#66728
Draft
Copilot wants to merge 5 commits into
Draft
Validation: skip static properties in generated model traversal#66728Copilot wants to merge 5 commits into
Copilot wants to merge 5 commits into
Conversation
1 task
Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/a42125f4-648d-44d7-bc40-25b3e6a30e2b Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/a42125f4-648d-44d7-bc40-25b3e6a30e2b Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/a42125f4-648d-44d7-bc40-25b3e6a30e2b Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/a42125f4-648d-44d7-bc40-25b3e6a30e2b Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix validation generator to ignore static properties
Validation: skip static properties in generated model traversal
May 18, 2026
javiercn
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip static properties during validation traversal
Description
Minimal API validation could recurse indefinitely when generated metadata included static self-referential properties (e.g.,
public static MyModel TheAnswer => new()). This change ensures static properties are ignored at runtime traversal, preventing false circular-depth failures.Runtime behavior change
ValidatablePropertyInfo.ValidateAsyncto skip validation for static properties.Regression coverage
Validate_IgnoresStaticPropertiesto verify static self-referential metadata does not recurse.Validate_ThrowsForRecursiveInstancePropertiesas a control to confirm instance recursion behavior is unchanged (max-depth still enforced).