Skip to content

Commit ab81350

Browse files
kotlarmilosCopilot
andauthored
Skip unsupported tests and increase timeouts for Apple mobile CI legs (#126464)
## Description Skip tests that throw `PlatformNotSupportedException` or fail due to platform-specific behavior on Apple mobile (iOS, tvOS, MacCatalyst) and Android devices. Fixes #126455 Fixes #126456 Fixes #126462 Fixes #126463 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 1065d3f commit ab81350

8 files changed

Lines changed: 12 additions & 6 deletions

File tree

eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ jobs:
186186
testGroup: innerloop
187187
nameSuffix: AllSubsets_CoreCLR_RuntimeTests
188188
buildArgs: -s clr+libs -c $(_BuildConfig)
189-
timeoutInMinutes: 240
189+
timeoutInMinutes: 360
190190
# extra steps, run tests
191191
extraVariablesTemplates:
192192
- template: /eng/pipelines/common/templates/runtimes/test-variables.yml

eng/pipelines/extra-platforms/runtime-extra-platforms-maccatalyst.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ jobs:
7777
testGroup: innerloop
7878
nameSuffix: AllSubsets_Mono_RuntimeTests
7979
buildArgs: -s mono+libs -c $(_BuildConfig)
80-
timeoutInMinutes: 240
80+
timeoutInMinutes: 360
8181
# extra steps, run tests
8282
extraVariablesTemplates:
8383
- template: /eng/pipelines/common/templates/runtimes/test-variables.yml
@@ -256,7 +256,7 @@ jobs:
256256
testGroup: innerloop
257257
nameSuffix: AllSubsets_CoreCLR_RuntimeTests
258258
buildArgs: -s clr+libs -c $(_BuildConfig)
259-
timeoutInMinutes: 240
259+
timeoutInMinutes: 360
260260
# extra steps, run tests
261261
extraVariablesTemplates:
262262
- template: /eng/pipelines/common/templates/runtimes/test-variables.yml

src/libraries/System.Diagnostics.Process/tests/ProcessHandlesTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
namespace System.Diagnostics.Tests
1010
{
1111
[SkipOnPlatform(TestPlatforms.Android, "sh is not available on Android")]
12+
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst, "Not supported on Apple mobile platforms.")]
1213
public class ProcessHandlesTests : ProcessTestBase
1314
{
1415
[Theory]

src/libraries/System.Diagnostics.Process/tests/ProcessTests.Unix.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,7 @@ public void TestBasePriorityOnUnix()
519519
}
520520

521521
[Fact]
522-
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on iOS or tvOS.")]
522+
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst, "Not supported on iOS, tvOS, or MacCatalyst.")]
523523
public void TestStartOnUnixWithBadPermissions()
524524
{
525525
string path = GetTestFilePath();

src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -402,14 +402,14 @@ public void ProcessStart_UseShellExecuteFalse_FilenameIsUrl_ThrowsWin32Exception
402402
}
403403

404404
[Fact]
405-
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on iOS and tvOS.")]
405+
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst, "Not supported on iOS, tvOS, and MacCatalyst.")]
406406
public void ProcessStart_TryOpenFolder_UseShellExecuteIsFalse_ThrowsWin32Exception()
407407
{
408408
Assert.Throws<Win32Exception>(() => Process.Start(new ProcessStartInfo { UseShellExecute = false, FileName = Path.GetTempPath() }));
409409
}
410410

411411
[Fact]
412-
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on iOS and tvOS.")]
412+
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst, "Not supported on iOS, tvOS, and MacCatalyst.")]
413413
public void TestStartWithBadWorkingDirectory()
414414
{
415415
string program;

src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostAddressesTest.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,7 @@ public async Task DnsGetHostAddresses_LocalhostSubdomain_RespectsAddressFamily(A
284284
// 3. Different systems configure localhost differently
285285
// The key requirement is that localhost subdomains return loopback addresses.
286286
[Fact]
287+
[ActiveIssue("https://github.com/dotnet/runtime/issues/126456", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst | TestPlatforms.Android)]
287288
public async Task DnsGetHostAddresses_LocalhostAndSubdomain_BothReturnLoopback()
288289
{
289290
IPAddress[] localhostAddresses = Dns.GetHostAddresses("localhost");

src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostEntryTest.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -449,6 +449,7 @@ public async Task DnsGetHostEntry_LocalhostSubdomain_RespectsAddressFamily(Addre
449449
// 3. Different systems configure localhost differently
450450
// The key requirement is that localhost subdomains return loopback addresses.
451451
[Fact]
452+
[ActiveIssue("https://github.com/dotnet/runtime/issues/126456", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst | TestPlatforms.Android)]
452453
public async Task DnsGetHostEntry_LocalhostAndSubdomain_BothReturnLoopback()
453454
{
454455
IPHostEntry localhostEntry = Dns.GetHostEntry("localhost");

src/tests/Regressions/coreclr/15241/genericcontext.ilproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk.IL">
2+
<PropertyGroup>
3+
<MonoAotIncompatible>true</MonoAotIncompatible>
4+
</PropertyGroup>
25
<ItemGroup>
36
<Compile Include="genericcontext.il" />
47
</ItemGroup>

0 commit comments

Comments
 (0)