Suggestion: include ruff's isort lint rule

[bradzacher]

https://docs.astral.sh/ruff/rules/#isort-i
https://docs.astral.sh/ruff/settings/#isort

At Canva we currently use dprint-plugin-exec to run both black and isort over the codebase.
I'm not sure how common this is externally - but I believe it's not uncommon to run both black + isort on a python codebase together - treating isort as a second formatter of sorts.

Ruff supports import sorting - so it would be great if we could leverage this and eliminate one more (slow) integration from the exec plugin.

[bradzacher]

For reference formatting ~5k files

• dprint-plugin-ruff plus isort via dprint-plugin-exec: ~2m30s.
• just dprint-plugin-ruff: ~12s

So there's a massive potential perf win here!

[dsherret]

I was also thinking about this, but I'm not sure how difficult it would be to implement (haven't looked into it and just going to sleep). Worst case, a pass on the CST could be done before or after formatting that does it.

[davo-canva]

If it helps anyone, the relevant module is here:

https://github.com/astral-sh/ruff/blob/5b726f70f49497cfcf49bd808be827056eac05e8/crates/ruff_linter/src/checkers/imports.rs#L79

[Avasam]

Unless you only want to sort exported members from a module import, and not sort the import lines themselves, isn't this unsafe to do for a formatter ? Import order very much matters.

[davo-canva]

technically unsafe, yes. if this is implemented it should probably be opt-in

[bradzacher]

For reference we currently use dprint-plugin-exec to allow us to do this

      // Python
      // ruff - import sorting
      {
        "cwd": "${originConfigDir}",
        // --select I001,F401 so it only removes unused imports and sorts them
        "command": "ruff check --config ruff.toml --select I001,F401 --fix-only --stdin-filename {{file_path}} --silent",
        "associations": ["**/*.{py,pyi}"],
        "stdin": true,
        "cacheKeyFiles": ["ruff.toml"],
      },
      // ruff - formatting
      {
        "cwd": "${originConfigDir}",
        "command": "ruff format --config ruff.toml --stdin-filename {{file_path}} --silent",
        "associations": ["**/*.{py,pyi}"],
        "stdin": true,
        "cacheKeyFiles": ["ruff.toml"],
      },

It's not perfect but it works.