Apologies for taking a look at #10 so late. Overall, awesome job!
I just have a few minor comments:
- Since the class in
src/stride/api/__init__.py is the "STRIDE UI Data API" (or arguably, just the "STRIDE Data API"), would it make sense for it to live in src/stride/api/data.py? And maybe the class should be DataAPIClient?
- Rename
energy_proj_table to energy_projection_table?
- Instructions for initializing
APIClient could be more specific in describing where the database.db and project config live within the STRIDE project files.
- Use
handle_stride_exception in the data API when raising errors for the user to deal with, per https://github.com/dsgrid/stride/pull/10/files#r2280931095
- Move
src/stride/ui/TODO.md to a git issue (or an issue per TODO)
Apologies for taking a look at #10 so late. Overall, awesome job!
I just have a few minor comments:
src/stride/api/__init__.pyis the "STRIDE UI Data API" (or arguably, just the "STRIDE Data API"), would it make sense for it to live insrc/stride/api/data.py? And maybe the class should beDataAPIClient?energy_proj_tabletoenergy_projection_table?APIClientcould be more specific in describing where thedatabase.dband project config live within the STRIDE project files.handle_stride_exceptionin the data API when raising errors for the user to deal with, per https://github.com/dsgrid/stride/pull/10/files#r2280931095src/stride/ui/TODO.mdto a git issue (or an issue per TODO)