From 564b5ce7cbccdbc3cf3783ddc9ec1b4034e75dc9 Mon Sep 17 00:00:00 2001 From: William Roebuck Date: Wed, 21 Jan 2026 13:58:55 +0000 Subject: [PATCH 1/5] Add unit test job --- .github/workflows/tests.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index ee14515c..6495c660 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -18,10 +18,17 @@ on: merge_group: types: [checks_requested] jobs: - test: + rust_tests: uses: eclipse-score/cicd-workflows/.github/workflows/tests.yml@main permissions: contents: read pull-requests: read with: bazel-target: 'test //src/...' + unit_test: + uses: eclipse-score/cicd-workflows/.github/workflows/tests.yml@main + permissions: + contents: read + pull-requests: read + with: + bazel-target: 'test //tests/ut/...' From 53f8a59e4ecef6da5052d305b92fb7a28760e8ba Mon Sep 17 00:00:00 2001 From: Pawel Rutka Date: Wed, 21 Jan 2026 14:05:45 +0100 Subject: [PATCH 2/5] Fix PhmDaemon init list order issue --- .../health_monitor_lib/src/score/lcm/saf/daemon/PhmDaemon.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/launch_manager_daemon/health_monitor_lib/src/score/lcm/saf/daemon/PhmDaemon.cpp b/src/launch_manager_daemon/health_monitor_lib/src/score/lcm/saf/daemon/PhmDaemon.cpp index 69c84308..b74650eb 100644 --- a/src/launch_manager_daemon/health_monitor_lib/src/score/lcm/saf/daemon/PhmDaemon.cpp +++ b/src/launch_manager_daemon/health_monitor_lib/src/score/lcm/saf/daemon/PhmDaemon.cpp @@ -37,7 +37,7 @@ namespace daemon processStateReader.", true_no_defect) */ PhmDaemon::PhmDaemon(score::lcm::saf::timers::OsClockInterface& f_osClock, logging::PhmLogger& f_logger_r, std::unique_ptr f_watchdog, std::unique_ptr f_process_state_receiver) : - osClock{f_osClock}, cycleTimer{&osClock}, logger_r{f_logger_r}, swClusterHandlers{}, watchdog(std::move(f_watchdog)), processStateReader{std::move(f_process_state_receiver)} + osClock{f_osClock}, cycleTimer{&osClock}, logger_r{f_logger_r}, swClusterHandlers{}, processStateReader{std::move(f_process_state_receiver)}, watchdog(std::move(f_watchdog)) { static_cast(f_osClock); } From d5e7765da52218b9e9e11232cd1fc18c171b1728 Mon Sep 17 00:00:00 2001 From: William Roebuck Date: Wed, 21 Jan 2026 14:59:51 +0000 Subject: [PATCH 3/5] Renamed jobs --- .github/workflows/tests.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 6495c660..b4d9f068 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -18,14 +18,16 @@ on: merge_group: types: [checks_requested] jobs: - rust_tests: + rust-tests: + name: "Run Rust tests" uses: eclipse-score/cicd-workflows/.github/workflows/tests.yml@main permissions: contents: read pull-requests: read with: bazel-target: 'test //src/...' - unit_test: + unit-tests: + name: "Run Unit tests" uses: eclipse-score/cicd-workflows/.github/workflows/tests.yml@main permissions: contents: read From 4829f031a295354ac8d5ffbecbf046daf7598750 Mon Sep 17 00:00:00 2001 From: William Roebuck Date: Thu, 22 Jan 2026 15:54:09 +0000 Subject: [PATCH 4/5] Simplified test action to prevent rebuilding for each test type --- .github/workflows/tests.yml | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index b4d9f068..301dcdc8 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -18,19 +18,11 @@ on: merge_group: types: [checks_requested] jobs: - rust-tests: - name: "Run Rust tests" + test: + name: "Run tests" uses: eclipse-score/cicd-workflows/.github/workflows/tests.yml@main permissions: contents: read pull-requests: read with: - bazel-target: 'test //src/...' - unit-tests: - name: "Run Unit tests" - uses: eclipse-score/cicd-workflows/.github/workflows/tests.yml@main - permissions: - contents: read - pull-requests: read - with: - bazel-target: 'test //tests/ut/...' + bazel-target: 'test //src/... //tests/ut/...' \ No newline at end of file From 9f7fda298428750355494b05cc207a018edb3933 Mon Sep 17 00:00:00 2001 From: William Roebuck Date: Thu, 22 Jan 2026 16:04:51 +0000 Subject: [PATCH 5/5] Fix formatting --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 301dcdc8..e239ab02 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -25,4 +25,4 @@ jobs: contents: read pull-requests: read with: - bazel-target: 'test //src/... //tests/ut/...' \ No newline at end of file + bazel-target: 'test //src/... //tests/ut/...'