Auto Edit broken

[cdietrich]

maybe by eclipse-platform/eclipse.platform.ui@1848058

eclipse-platform/eclipse.platform.ui#3074

#3530 (comment)

[cdietrich]

to verify commit above is causer:
import platform.ui bundles from git
checkout commit above
see if test fails
go one commit back
see if it still fails

[cdietrich]

maybe this change in particular

if (!performOutsideVisibleRegion && overlapsWithNonVisibleRegions(offset, length)) {
return;
}

[cdietrich]

confirmed

Bildschirmaufnahme.2025-10-13.um.20.12.22.mov

[cdietrich]

but i have no clue why the comment is intially folded....
maybe it always was
but hitting enter did unfold and then edit anyway

[cdietrich]

old behaviour

Bildschirmaufnahme.2025-10-13.um.20.19.37.mov

[iloveeclipse]

Would eclipse-platform/eclipse.platform.ui#3390 fix the problem?

[cdietrich]

no it wont

[iloveeclipse]

I assume the code is in some subclass of https://github.com/eclipse-xtext/xtext/blob/main/org.eclipse.xtext.ui.testing/src/org/eclipse/xtext/ui/testing/AbstractAutoEditTest.java ?

[cdietrich]

the failing test is

org.eclipse.xtext.ui.testing.AbstractCStyleLanguageAutoEditTest.testBug453205_01()
called via subclass

org.eclipse.xtend.ide.tests.autoedit.AutoEditTest

the strategy is in org.eclipse.xtext.ui.editor.autoedit.MultiLineTerminalsEditStrategy
via org.eclipse.xtend.ide.autoedit.AutoEditStrategyProvider / org.eclipse.xtext.ui.editor.autoedit.DefaultAutoEditStrategyProvider

[cdietrich]

when i comment out the early return in expand, test is green again

[merks]

Kudos for the excellent, detailed investigation!

[LorenzoBettini]

when i comment out the early return in expand, test is green again

you mean in the platform code?