Skip to content

incorrect external workspace assumption #57

@comicfans

Description

@comicfans

I tried to import bazel source code using bazel-eclipse,

https://github.com/eclipseguru/bazel-eclipse/blob/0f60e45de15e2a14a8b6cda046b69c0ed169b4e7/bundles/com.salesforce.bazel.eclipse.core/src/com/salesforce/bazel/eclipse/core/model/BazelWorkspace.java#L473-482

public BazelWorkspace getExternalWorkspace(IPath externalRoot) throws IllegalArgumentException, CoreException {
        if (!getInfo().getOutputBase().isPrefixOf(externalRoot)) {
            throw new IllegalArgumentException(
                    format(
                        "The external workspace at '%s' is not rooted in the output base of workspace '%s'!",
                        externalRoot,
                        getLocation()));
        }
        return new BazelWorkspace(externalRoot, this);
    }

it assume external workspace should live under externalRoot, which is incorrect, for example bazel/third_party/remoteapis live under main repo directory

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions