Roadmap

[beck]

This repo now has few more maintainers (including myself).

Before making any big changes would like to:

Say Hi

hi

Make a todo list

1. Rewrite tests and use real browsers to run them: Rewrite tests  #69
2. Fix ReferenceError: self is not defined #48
3. Publish a new version
4. Close my fork Deprecate this repo yola/classlist-polyfill#9
5. Cleanup whitespace
6. Minify via npm prepublish
7. Start addressing open issues

Flesh out any preferences, paint a bikeshed

When writing JS I generally stick to airbnb-ish style.

For testing, prefer Mocha+chai (with karma running the tests) instead of QUnit.

Prefer plain old shell or JS scripts instead task managers.

[stevenvachon]

I fixed #48 in the "Consolidated closures" commit in #53.
I fixed whitespace in the "Whitespace fixes" commit in #53.
I rewrote the tests in the "Improve tests" commit in #53.

There are "..." buttons on those commits for you to read further commenting, in case you aren't familiar with GitHub.

prepublish is also ran on postinstall in npm <5. Likely not ideal at the moment. Use https://npmjs.com/in-publish

[beck]

@stevenvachon another preference is for single-purpose pull requests.

I agree with @eligrey about #53. IMO it does too much at once. Before the closures can be consolidated, lets cleanup the whitespace. Before we touch every line with whitespace cleanup, lets get the tests in working condition. I would expect a fix for #48 to have a diff of ~2 lines, something like:

-}(self));
+}(typeof self !== 'undefined' ? self : this));

[stevenvachon]

The whitespace commit occurs before the closure consolidation commit. You can click each commit to see its specific code changes.

[englishextra]

-}(self));
+}(typeof self !== 'undefined' ? self : this));

This is what I do with every polyfill I deal with.

BTW I'm gonna send a PR regarding !a===!b at the bottom of the polyfill, tha last thing which is a thorn.

[euwest]

@stevenvachon:

another preference is for single-purpose pull requests.

I agree ... about #53. IMO it does too much at once.

That's @beck responding to:

I fixed #48 in the "Consolidated closures" commit in #53.
I fixed whitespace in the "Whitespace fixes" commit in #53.
I rewrote the tests in the "Improve tests" commit in #53.

He's telling you he would like those to be separate PRs, not just separate commits. Condescension is not an appropriate response.

[stevenvachon]

He's telling you he would like those to be separate PRs, not just separate commits. Condescension is not an appropriate response.

And I'm telling him and anyone else that they can go through the commits. I have little interest in redoing my PRs after all this time.