Skip to content

Commit 780bb55

Browse files
committed
Default to SemVerCompareStrategy in StringVersion
Updated StringVersion to always use SemVerCompareStrategy instead of conditionally selecting between SemVerCompareStrategy and DefaultCompareStrategy. This simplifies the logic and enforces consistent version comparison behavior.
1 parent d5b75c3 commit 780bb55

1 file changed

Lines changed: 2 additions & 9 deletions

File tree

src/System.StringVersion/StringVersion.cs

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,7 @@ public StringVersion(string? original)
3030
VersionToken[] tokens = Tokenizer.Tokenize(original.AsSpan());
3131
_tokens = tokens;
3232
Original = original ?? string.Empty;
33-
bool hasPre = false;
34-
bool hasBuild = false;
35-
foreach (VersionToken t in tokens)
36-
{
37-
if (t.Kind == VersionTokenKind.PreRelease) hasPre = true;
38-
if (t.Kind == VersionTokenKind.BuildMetadata) hasBuild = true;
39-
}
40-
Strategy = (hasPre || hasBuild) ? SemVerCompareStrategy.Instance : DefaultCompareStrategy.Instance;
33+
Strategy = SemVerCompareStrategy.Instance;
4134
}
4235

4336
/// <summary>
@@ -50,7 +43,7 @@ public StringVersion(VersionToken[] tokens, string? original, IVersionCompareStr
5043
{
5144
_tokens = tokens ?? [];
5245
Original = original ?? string.Empty;
53-
Strategy = strategy ?? DefaultCompareStrategy.Instance;
46+
Strategy = strategy ?? SemVerCompareStrategy.Instance;
5447
}
5548

5649
/// <summary>

0 commit comments

Comments
 (0)