Avoid mutating module exports.

[rwjblue]

We should stop mutating the modules exports.

This was needed while ember-cli was using amdStrict mode (since it did not use the _interopRequireDefault babel helper), and that is being unrolled in ember-cli/ember-cli#6827.

Suggested migration path is:

• Change makeDefaultExport to use Object.defineProperty(exports, 'default,...) with a getter that issues a deprecation warning in debug builds (avoiding Object.defineProperty in prod builds).
• Remove deprecation and method after major version bump to loader.js@5.0.0.

[rwjblue]

This has reared its ugly head again. See description in mike-north/ember-lodash#104.

We need to move forward and kill makeDefaultExport. I am tired of wasting time debugging things in phantom due to this behavior. 😩

[lennyburdette]

@rwjblue I'm happy to take this on. We (Square) are finally migrating to Ember CLI and we're trying to switch out our custom module runtime with loader.js ahead of time to discover any subtle incompatibilities. The cyclical default property is the first obvious issue.

One question:

What do you mean by "debug build"? Unless I'm missing something, there's only a prod build (dist/loader/loader.js) and an instrumented build (dist/loader/loader.instrument.js). Do we need to update build.js to output a loader.debug.js? And how would we get an Ember CLI build to use the debug build in development/test and the prod build in production?

The benchmarks load the instrumented or prod build conditionally, but I'm not seeing the instrumented build referenced elsewhere.

Thanks!

[lennyburdette]

Ack: I just noticed the ember-addon code in index.js. I think I know how to proceed. But if you have any similar debug builds I could model this after, please let me know!

[rwjblue]

This library is now an ember-cli addon, we directly app.import the specific transpiled dist file that we need. We have a build script that we use to generate those pre-built assets.

Rough steps:

• update babel version in use by the build script to 6
• add babel-plugin-debug-macros
• import debug flag and use if statements to guard the debug only code
• update build script to emit debug, prod, instrumented debug, instrumented prod files
• update included hook to app.import the "right" file

Happy to discuss further, feel free to ping me here or in the community slack...