Fixed a few issues

Problem: When the user is already added to persistence, and user signs in for the first time the dummy values in persistence were not getting updated.
Solution: Updating all the user details when the user signs in for the first time. When we fill the strategy vs id on the user object for the first time.

Problem: OauthToken constructor would throw Error when values are null, but null are usually expected for OauthToken
Solution: Updated the constructor to accept nulls too.

Author: abhayjatindoshi

composer.json

@@ -15,7 +15,7 @@
         }
     },
     "require": {
-        "encryptorcode/php-http-client": "^1.0",
-        "encryptorcode/php-server-utils": "^1.0"
+        "encryptorcode/php-http-client": "v1.0.0",
+        "encryptorcode/php-server-utils": "v1.0.1"
     }
 }

composer.lock

@@ -6,7 +6,7 @@ class OauthToken implements \JsonSerializable{
     private $refreshToken;
     private $expiryTime;
 
-    public function __construct(string $accessToken, string $refreshToken, int $expiryTime) {
+    public function __construct(?string $accessToken, ?string $refreshToken, ?int $expiryTime) {
         $this->accessToken = $accessToken;
         $this->refreshToken = $refreshToken;
         $this->expiryTime = $expiryTime;

src/oauth/OauthToken.php

@@ -82,24 +82,13 @@ public function oauthCallback() : void{
                 throw new OauthException("User was not allowed to login.");
             }
 
-            $fullName = $authUser->getFullName();
-            if(!isset($fullName)){
-                $authUser->setFullName($oauthUser->getFullName());
-            }
-
-            $name = $authUser->getName();
-            if(!isset($name)){
-                $authUser->setName($oauthUser->getName());
-            }
-
-            $profile = $authUser->getProfileImage();
-            if(!isset($profile)){
-                $authUser->setProfileImage($oauthUser->getProfileImage());
-            }
-
             $strategyVsIdMap = $authUser->getStrategyVsIdMap();
             if(!isset($strategyVsIdMap)){
                 $strategyVsIdMap = array();
+
+                $authUser->setFullName($oauthUser->getFullName());
+                $authUser->setName($oauthUser->getName());
+                $authUser->setProfileImage($oauthUser->getProfileImage());
             }
 
             $strategyVsIdMap[$strategyName] = $oauthUser->getOauthId();