FAIL: TestCustomProviderCancelWhenStarting

[kkk777-7]

happen DATA RACE warning

==================
WARNING: DATA RACE
Read at 0x00c0018e1253 by goroutine 390:
  testing.(*common).destination()
      /opt/hostedtoolcache/go/1.26.1/x64/src/testing/testing.go:1064 +0x1cc
  testing.(*outputWriter).Write()
      /opt/hostedtoolcache/go/1.26.1/x64/src/testing/testing.go:1142 +0x9a
  go.uber.org/zap/zapcore.(*writerWrapper).Write()
      <autogenerated>:1 +0x5b
  go.uber.org/zap/zapcore.(*ioCore).Write()
      /home/runner/go/pkg/mod/go.uber.org/zap@v1.27.1/zapcore/core.go:99 +0x201
  go.uber.org/zap/zapcore.(*CheckedEntry).Write()
      /home/runner/go/pkg/mod/go.uber.org/zap@v1.27.1/zapcore/entry.go:258 +0x215
  github.com/go-logr/zapr.(*zapLogger).Info()
      /home/runner/go/pkg/mod/github.com/go-logr/zapr@v1.3.0/zapr.go:201 +0xce
  github.com/go-logr/logr.Logger.Info()
      /home/runner/go/pkg/mod/github.com/go-logr/logr@v1.4.3/logr.go:280 +0x107
  github.com/envoyproxy/gateway/internal/provider/kubernetes.(*gatewayAPIReconciler).updateStatusFromSubscriptions.func10()
      /home/runner/work/gateway/gateway/internal/provider/kubernetes/status.go:408 +0x1d3

Previous write at 0x00c0018e1253 by goroutine 129:
  testing.tRunner.func1()
      /opt/hostedtoolcache/go/1.26.1/x64/src/testing/testing.go:2023 +0x904
  runtime.deferreturn()
      /opt/hostedtoolcache/go/1.26.1/x64/src/runtime/panic.go:668 +0x5d
  testing.(*T).Run.gowrap1()
      /opt/hostedtoolcache/go/1.26.1/x64/src/testing/testing.go:2101 +0x38

Goroutine 390 (running) created at:
  github.com/envoyproxy/gateway/internal/provider/kubernetes.(*gatewayAPIReconciler).updateStatusFromSubscriptions()
      /home/runner/work/gateway/gateway/internal/provider/kubernetes/status.go:374 +0x599
  github.com/envoyproxy/gateway/internal/provider/kubernetes.NewOfflineGatewayAPIController()
      /home/runner/work/gateway/gateway/internal/provider/kubernetes/controller_offline.go:127 +0x1806
  github.com/envoyproxy/gateway/internal/provider/file.New()
      /home/runner/work/gateway/gateway/internal/provider/file/file.go:59 +0x615
  github.com/envoyproxy/gateway/internal/provider/runner.(*Runner).createCustomResourceProvider()
      /home/runner/work/gateway/gateway/internal/provider/runner/runner.go:95 +0x1a4
  github.com/envoyproxy/gateway/internal/provider/runner.(*Runner).Start()
      /home/runner/work/gateway/gateway/internal/provider/runner/runner.go:58 +0x587
  github.com/envoyproxy/gateway/internal/cmd.startRunner()
      /home/runner/work/gateway/gateway/internal/cmd/server.go:304 +0x1d1
  github.com/envoyproxy/gateway/internal/cmd.startRunners()
      /home/runner/work/gateway/gateway/internal/cmd/server.go:260 +0x1ea8
  github.com/envoyproxy/gateway/internal/cmd.TestRunnerGoroutineRaceStress.func1.1()
      /home/runner/work/gateway/gateway/internal/cmd/server_runner_race_test.go:97 +0x154
  github.com/envoyproxy/gateway/internal/envoygateway/config/loader.(*Loader).runHook.func1()
      /home/runner/work/gateway/gateway/internal/envoygateway/config/loader/configloader.go:129 +0x13d
  github.com/envoyproxy/gateway/internal/envoygateway/config/loader.(*Loader).runHook.gowrap1()
      /home/runner/work/gateway/gateway/internal/envoygateway/config/loader/configloader.go:135 +0x46

Goroutine 129 (finished) created at:
  testing.(*T).Run()
      /opt/hostedtoolcache/go/1.26.1/x64/src/testing/testing.go:2101 +0xb12
  testing.runTests.func1()
      /opt/hostedtoolcache/go/1.26.1/x64/src/testing/testing.go:2585 +0x85
  testing.tRunner()
      /opt/hostedtoolcache/go/1.26.1/x64/src/testing/testing.go:2036 +0x21c
  testing.runTests()
      /opt/hostedtoolcache/go/1.26.1/x64/src/testing/testing.go:2583 +0x9e9
  testing.(*M).Run()
      /opt/hostedtoolcache/go/1.26.1/x64/src/testing/testing.go:2443 +0xf4b
  main.main()
      _testmain.go:78 +0x164
==================
--- FAIL: TestCustomProviderCancelWhenStarting (0.75s)
    testing.go:1712: race detected during execution of test

https://github.com/envoyproxy/gateway/actions/runs/23224636373/job/67504617287?pr=8538

[nishantbkl3345-ship-it]

Hi, I’d like to take a look at this issue.

The stack trace seems to point to a goroutine in updateStatusFromSubscriptions continuing to log while the test is shutting down, so I’ll start by tracing the cancellation and shutdown path there.