Skip to content

Conversation

@amareshsm
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

  • Avoid duplicate main landmarks/IDs.
  • add relationships (controls) between the nav toggle and its menu.
  • Simplify the playground Popup component by removing unused/half‑implemented code

What changes did you make? (Give an overview)

  • Updated the playground’s main region ID
  • Added aria-controls to the mobile nav toggle button
  • Simplified Popup by removing unused options / showOptions state and the dead options list, keeping only the currently-used Fix button:

Related Issues

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Dec 1, 2025
@netlify
Copy link

netlify bot commented Dec 1, 2025

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 0b43474
🔍 Latest deploy log https://app.netlify.com/projects/es-eslint/deploys/692e79b9f102ad0008a695f6
😎 Deploy Preview https://deploy-preview-858--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 1, 2025

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 0b43474
🔍 Latest deploy log https://app.netlify.com/projects/ja-eslint/deploys/692e79b90e39c1000857caa3
😎 Deploy Preview https://deploy-preview-858--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 1, 2025

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit 0b43474
🔍 Latest deploy log https://app.netlify.com/projects/new-eslint/deploys/692e79b9ce0474000766cbc0
😎 Deploy Preview https://deploy-preview-858--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 1, 2025

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 0b43474
🔍 Latest deploy log https://app.netlify.com/projects/hi-eslint/deploys/692e79b9defd3a000854619b
😎 Deploy Preview https://deploy-preview-858--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 1, 2025

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 0b43474
🔍 Latest deploy log https://app.netlify.com/projects/zh-hans-eslint/deploys/692e79b944f6ab00088831da
😎 Deploy Preview https://deploy-preview-858--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 1, 2025

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 0b43474
🔍 Latest deploy log https://app.netlify.com/projects/fr-eslint/deploys/692e79b937e8630008a8f1d7
😎 Deploy Preview https://deploy-preview-858--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 1, 2025

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 0b43474
🔍 Latest deploy log https://app.netlify.com/projects/de-eslint/deploys/692e79b94f6fa80008bcebcb
😎 Deploy Preview https://deploy-preview-858--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 1, 2025

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 0b43474
🔍 Latest deploy log https://app.netlify.com/projects/pt-br-eslint/deploys/692e79b9c836c30008637f81
😎 Deploy Preview https://deploy-preview-858--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lumirlumir
Copy link
Member

It looks like there's a merge conflict now.

@lumirlumir lumirlumir moved this from Needs Triage to Triaging in Triage Dec 2, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Would like one more review from the team before merging.

@lumirlumir lumirlumir moved this from Triaging to Second Review Needed in Triage Dec 2, 2025
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, there is another approval, so I'm merging it.

@lumirlumir lumirlumir merged commit 0e28346 into main Dec 6, 2025
37 checks passed
@lumirlumir lumirlumir deleted the fix-accessability-issue branch December 6, 2025 13:50
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants