From 16550656ecd4aa58574bab733ebde32ccf73d619 Mon Sep 17 00:00:00 2001 From: chriscummings Date: Mon, 7 Jul 2025 12:54:30 -0500 Subject: [PATCH] fix(route_manager history): move history update to after model save --- scram/route_manager/api/serializers.py | 2 -- scram/route_manager/api/views.py | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scram/route_manager/api/serializers.py b/scram/route_manager/api/serializers.py index 62ade3f7..96283335 100644 --- a/scram/route_manager/api/serializers.py +++ b/scram/route_manager/api/serializers.py @@ -6,7 +6,6 @@ from netfields import rest_framework from rest_framework import serializers from rest_framework.fields import CurrentUserDefault -from simple_history.utils import update_change_reason from ..models import ActionType, Client, Entry, IgnoreEntry, Route @@ -96,7 +95,6 @@ def create(validated_data): entry_instance, _ = Entry.objects.get_or_create(route=route_instance, actiontype=actiontype_instance) logger.debug("Created entry with comment: %s", comment) - update_change_reason(entry_instance, comment) return entry_instance diff --git a/scram/route_manager/api/views.py b/scram/route_manager/api/views.py index 9e6e5591..16fc59d7 100644 --- a/scram/route_manager/api/views.py +++ b/scram/route_manager/api/views.py @@ -14,6 +14,7 @@ from rest_framework import status, viewsets from rest_framework.permissions import AllowAny, IsAuthenticated from rest_framework.response import Response +from simple_history.utils import update_change_reason from ..models import ActionType, Client, Entry, IgnoreEntry, WebSocketSequenceElement from .exceptions import ActiontypeNotAllowed, IgnoredRoute, PrefixTooLarge @@ -162,6 +163,7 @@ def perform_create(self, serializer): entry.originating_scram_instance = settings.SCRAM_HOSTNAME logger.info("Created entry: %s", entry) entry.save() + update_change_reason(entry, comment) @staticmethod def find_entries(arg, active_filter=None):