Review feedback

Author: alpe

block/components.go

@@ -36,17 +36,6 @@ type Components struct {
 	errorCh chan error
 }
 
-// GetLastState returns the current blockchain state
-func (bc *Components) GetLastState() types.State {
-	if bc.Executor != nil {
-		return bc.Executor.GetLastState()
-	}
-	if bc.Syncer != nil {
-		return bc.Syncer.GetLastState()
-	}
-	return types.State{}
-}
-
 // Start starts all components and monitors for critical errors.
 // It is blocking and returns when the context is cancelled or an error occurs
 func (bc *Components) Start(ctx context.Context) error {

block/internal/executing/executor.go

@@ -175,13 +175,6 @@ func (e *Executor) Stop() error {
 	return nil
 }
 
-// GetLastState returns the current state.
-func (e *Executor) GetLastState() types.State {
-	state := e.getLastState()
-	state.AppHash = bytes.Clone(state.AppHash)
-	return state
-}
-
 // getLastState returns the current state.
 // getLastState should never directly mutate.
 func (e *Executor) getLastState() types.State {

block/internal/syncing/syncer.go

@@ -289,27 +289,6 @@ drainLoop:
 	return nil
 }
 
-// isCatchingUpState returns true if the syncer has pending events or is behind the current raft height
-func (s *Syncer) isCatchingUpState() bool {
-	return len(s.heightInCh) != 0 || func() bool {
-		currentHeight, err := s.store.Height(s.ctx)
-		if err != nil {
-			s.logger.Error().Err(err).Msg("failed to get current height")
-			return false
-		}
-		return s.headerStore.Store().Height() > currentHeight ||
-			s.dataStore.Store().Height() > currentHeight ||
-			s.raftRetriever != nil && s.raftRetriever.Height() > currentHeight
-	}()
-}
-
-// GetLastState returns the current state.
-func (e *Syncer) GetLastState() types.State {
-	state := e.getLastState()
-	state.AppHash = bytes.Clone(state.AppHash)
-	return state
-}
-
 // getLastState returns the current state
 func (s *Syncer) getLastState() types.State {
 	state := s.lastState.Load()
@@ -1239,15 +1218,6 @@ func (s *Syncer) cancelP2PWait(height uint64) {
 	}
 }
 
-// IsSynced checks if the last block height in the stored state matches the expected height and returns true if they are equal.
-func (s *Syncer) IsSynced(expHeight uint64) bool {
-	state, err := s.store.GetState(s.ctx)
-	if err != nil {
-		return false
-	}
-	return state.LastBlockHeight == expHeight && !s.isCatchingUpState()
-}
-
 // IsSyncedWithRaft checks if the local state is synced with the given raft state, including hash check.
 func (s *Syncer) IsSyncedWithRaft(raftState *raft.RaftBlockState) (int, error) {
 	state, err := s.store.GetState(s.ctx)