fix: make evm_execution more robust (#2942)

<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.

NOTE: PR titles should follow semantic commits:
https://www.conventionalcommits.org/en/v1.0.0/
-->

## Overview

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 

Ex: Closes #<issue number>
-->


### Summary

Prevents fork explosions where multiple EL blocks are created for the
same app block height by adding three layers of protection:

1. **Idempotency check** - Before building, checks if EL already has a
block at the requested height with matching timestamp and reuses it
2. **Fixed safe/finalized semantics** - `setFinal(isFinal=false)` no
longer incorrectly advances safe block; safe now lags head by
`SafeBlockLag` (2 blocks)

### Changes

- Added `executeMu sync.Mutex` to serialize `ExecuteTxs` and
`ResumePayload` calls
- Added idempotency check at start of `ExecuteTxs` using height +
timestamp matching
- Fixed forkchoice args to use tracked
`currentSafeBlockHash`/`currentFinalizedBlockHash` instead of
`prevBlockHash`
- Added `SafeBlockLag` constant (2 blocks) for automatic safe block
advancement
- Added new APIs: `SetSafe()`, `SetSafeByHeight()`, `SetFinalized()`,
`ResumePayload()`
- Refactored common RPC logic into `doForkchoiceUpdate()

Author: tac0turtle

apps/evm/cmd/run.go

@@ -43,17 +43,23 @@ var RunCmd = &cobra.Command{
 	Aliases: []string{"node", "run"},
 	Short:   "Run the evolve node with EVM execution client",
 	RunE: func(cmd *cobra.Command, args []string) error {
-		executor, err := createExecutionClient(cmd)
+		nodeConfig, err := rollcmd.ParseConfig(cmd)
 		if err != nil {
 			return err
 		}
 
-		nodeConfig, err := rollcmd.ParseConfig(cmd)
+		logger := rollcmd.SetupLogger(nodeConfig.Log)
+
+		// Create datastore first - needed by execution client for ExecMeta tracking
+		datastore, err := store.NewDefaultKVStore(nodeConfig.RootDir, nodeConfig.DBPath, evmDbName)
 		if err != nil {
 			return err
 		}
 
-		logger := rollcmd.SetupLogger(nodeConfig.Log)
+		executor, err := createExecutionClient(cmd, datastore)
+		if err != nil {
+			return err
+		}
 
 		blobClient, err := blobrpc.NewClient(context.Background(), nodeConfig.DA.Address, nodeConfig.DA.AuthToken, "")
 		if err != nil {
@@ -72,11 +78,6 @@ var RunCmd = &cobra.Command{
 
 		logger.Info().Str("headerNamespace", headerNamespace.HexString()).Str("dataNamespace", dataNamespace.HexString()).Msg("namespaces")
 
-		datastore, err := store.NewDefaultKVStore(nodeConfig.RootDir, nodeConfig.DBPath, evmDbName)
-		if err != nil {
-			return err
-		}
-
 		genesisPath := filepath.Join(filepath.Dir(nodeConfig.ConfigPath()), "genesis.json")
 		genesis, err := genesispkg.LoadGenesis(genesisPath)
 		if err != nil {
@@ -200,7 +201,7 @@ func createSequencer(
 	return sequencer, nil
 }
 
-func createExecutionClient(cmd *cobra.Command) (execution.Executor, error) {
+func createExecutionClient(cmd *cobra.Command, db datastore.Batching) (execution.Executor, error) {
 	// Read execution client parameters from flags
 	ethURL, err := cmd.Flags().GetString(evm.FlagEvmEthURL)
 	if err != nil {
@@ -245,7 +246,7 @@ func createExecutionClient(cmd *cobra.Command) (execution.Executor, error) {
 	genesisHash := common.HexToHash(genesisHashStr)
 	feeRecipient := common.HexToAddress(feeRecipientStr)
 
-	return evm.NewEngineExecutionClient(ethURL, engineURL, jwtSecret, genesisHash, feeRecipient)
+	return evm.NewEngineExecutionClient(ethURL, engineURL, jwtSecret, genesisHash, feeRecipient, db)
 }
 
 // addFlags adds flags related to the EVM execution client

buf.gen.evm.yaml

@@ -0,0 +1,11 @@
+version: v2
+
+plugins:
+  - remote: buf.build/protocolbuffers/go
+    out: execution/evm/types/pb
+    opt: paths=source_relative
+  - remote: buf.build/connectrpc/go
+    out: execution/evm/types/pb
+    opt: paths=source_relative
+inputs:
+  - directory: proto

buf.gen.yaml

@@ -1,5 +1,4 @@
 version: v2
-clean: true
 
 plugins:
   - remote: buf.build/protocolbuffers/go