Skip to content

Commit a6a859e

Browse files
authored
Refactoring/680 remove needs in checks (#681)
* Remove not required needs * Move single liners to be single lines in yaml * Update PTB workflow with template * Add question mark to step requiring manual approval (when activated) * Remove private repo information * Prepare release 5.1.0
1 parent b0c5b28 commit a6a859e

File tree

12 files changed

+36
-75
lines changed

12 files changed

+36
-75
lines changed

.github/actions/security-issues/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ runs:
3939
- name: Install Python Toolbox / Security tool
4040
shell: bash
4141
run: |
42-
pip install exasol-toolbox==5.0.0
42+
pip install exasol-toolbox==5.1.0
4343
4444
- name: Create Security Issue Report
4545
shell: bash

.github/workflows/checks.yml

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626

2727
Documentation:
2828
name: Docs
29-
needs: [ Version-Check ]
3029
runs-on: "ubuntu-24.04"
3130
permissions:
3231
contents: read
@@ -41,12 +40,10 @@ jobs:
4140
poetry-version: "2.3.0"
4241

4342
- name: Build Documentation
44-
run: |
45-
poetry run -- nox -s docs:build
43+
run: poetry run -- nox -s docs:build
4644

4745
- name: Link Check
48-
run: |
49-
poetry run -- nox -s links:check
46+
run: poetry run -- nox -s links:check
5047

5148
Changelog:
5249
name: Changelog Update Check
@@ -69,7 +66,6 @@ jobs:
6966

7067
Lint:
7168
name: Linting (Python-${{ matrix.python-versions }})
72-
needs: [ Version-Check ]
7369
runs-on: "ubuntu-24.04"
7470
permissions:
7571
contents: read
@@ -101,7 +97,6 @@ jobs:
10197

10298
Type-Check:
10399
name: Type Checking (Python-${{ matrix.python-versions }})
104-
needs: [ Version-Check ]
105100
runs-on: "ubuntu-24.04"
106101
permissions:
107102
contents: read
@@ -125,7 +120,6 @@ jobs:
125120

126121
Security:
127122
name: Security Checks (Python-${{ matrix.python-versions }})
128-
needs: [ Version-Check ]
129123
runs-on: "ubuntu-24.04"
130124
permissions:
131125
contents: read
@@ -175,7 +169,6 @@ jobs:
175169

176170
Build-Packages:
177171
name: Build Package Check
178-
needs: [ Documentation, Lint, Type-Check, Security, Format ]
179172
runs-on: "ubuntu-24.04"
180173
permissions:
181174
contents: read
@@ -212,7 +205,6 @@ jobs:
212205

213206
Tests:
214207
name: Unit-Tests (Python-${{ matrix.python-versions }})
215-
needs: [ Build-Packages, Lint-Imports ]
216208
runs-on: "ubuntu-24.04"
217209
permissions:
218210
contents: read

.github/workflows/merge-gate.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
contents: read
1313

1414
run-slow-tests:
15-
name: Run Slow Tests
15+
name: Run Slow Tests?
1616
runs-on: "ubuntu-24.04"
1717
permissions:
1818
contents: read

doc/changes/changelog.md

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

doc/changes/changes_5.1.0.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# 5.1.0 - 2026-01-29
2+
3+
## Summary
4+
5+
## Feature
6+
7+
* #673: Switched `checks.yml` to get Python versions for matrix from `BaseConfig`
8+
9+
## Documentation
10+
11+
* #676: Moved GitHub Workflows to be inside features & updated
12+
* #658: Removed configuration of Sonar for private repos
13+
14+
## Refactoring
15+
16+
* #680: Removed `needs` from `checks.yml`
17+
18+
## Dependency Updates
19+
20+
### `main`
21+
* Added dependency `sphinxcontrib-mermaid:2.0.0`

doc/changes/unreleased.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,3 @@
11
# Unreleased
22

33
## Summary
4-
5-
## Feature
6-
7-
* #673: Switched `checks.yml` to get Python versions for matrix from `BaseConfig`
8-
9-
## Documentation
10-
11-
* #676: Move GitHub Workflows to be inside features & updated

doc/user_guide/features/metrics/sonar.rst

Lines changed: 3 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -62,49 +62,11 @@ In the code
6262

6363
**Private** GitHub repository
6464
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
65-
.. note::
66-
As of 2025-07-29, these instructions have not been used. Thus, they should be
67-
scrutinized and refined when they are used to configure a private repository.
68-
69-
In GitHub
70-
"""""""""
71-
A GitHub Admin will need to:
72-
73-
#. Add the individual 'PRIVATE_SONAR_TOKEN' to the 'Organization secrets'
74-
#. Activate the `exasonarqubeprchecks App <https://github.com/apps/exasonarqubeprchecks>`__
75-
#. **Post-merge**: update the branch protections to include SonarQube analysis.
76-
77-
* This should only be done when tests exist for the project, & that the project is
78-
at a state in which enforced code coverage would not be a burden. If you do
79-
not enact branch protections, it is recommended to create an issue to do so later.
80-
81-
In Sonar
82-
""""""""
83-
An IT Admin will need to:
84-
85-
#. Create a project on https://sonar.exasol.com
86-
87-
* Project key should follow this pattern, e.g. ``com.exasol:python-toolbox``
88-
89-
90-
In the code
91-
"""""""""""
92-
#. Specify in the ``noxconfig.py`` the relative path to the project's source code in ``Config.source``
93-
.. code-block:: python
94-
95-
source: Path = Path("exasol/<source-directory>")
96-
97-
#. Add the following to the project's file ``pyproject.toml``
98-
.. code-block:: toml
99-
100-
[tool.sonar]
101-
projectKey = "com.exasol:<project-key>"
102-
host.url = "https://sonar.exasol.com"
103-
organization = "exasol"
104-
exclusions = "<source-directory>/version.py,<source_directory>/<directory-to-ignore>/*"
65+
See the company wiki for details on how to use Exasol's on-prem SonarQube cluster
66+
and the needed steps to configure for a private GitHub repository.
10567

10668
.. note::
107-
For more information, see the :ref:`General remarks <configuration_general_remarks>` section.
69+
For more general information, see the :ref:`General remarks <configuration_general_remarks>` section.
10870

10971
.. _Exasol Way: https://sonarcloud.io/organizations/exasol/quality_gates/show/AXxvLH-3BdtLlpiYmZhh
11072
.. _Sonar Matching Patterns: https://docs.sonarsource.com/sonarqube-server/project-administration/adjusting-analysis/setting-analysis-scope/defining-matching-patterns

exasol/toolbox/templates/github/workflows/checks.yml

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626

2727
Documentation:
2828
name: Docs
29-
needs: [ Version-Check ]
3029
runs-on: "(( os_version ))"
3130
permissions:
3231
contents: read
@@ -41,12 +40,10 @@ jobs:
4140
poetry-version: "(( dependency_manager_version ))"
4241

4342
- name: Build Documentation
44-
run: |
45-
poetry run -- nox -s docs:build
43+
run: poetry run -- nox -s docs:build
4644

4745
- name: Link Check
48-
run: |
49-
poetry run -- nox -s links:check
46+
run: poetry run -- nox -s links:check
5047

5148
Changelog:
5249
name: Changelog Update Check
@@ -69,7 +66,6 @@ jobs:
6966

7067
Lint:
7168
name: Linting (Python-${{ matrix.python-versions }})
72-
needs: [ Version-Check ]
7369
runs-on: "(( os_version ))"
7470
permissions:
7571
contents: read
@@ -101,7 +97,6 @@ jobs:
10197

10298
Type-Check:
10399
name: Type Checking (Python-${{ matrix.python-versions }})
104-
needs: [ Version-Check ]
105100
runs-on: "(( os_version ))"
106101
permissions:
107102
contents: read
@@ -125,7 +120,6 @@ jobs:
125120

126121
Security:
127122
name: Security Checks (Python-${{ matrix.python-versions }})
128-
needs: [ Version-Check ]
129123
runs-on: "(( os_version ))"
130124
permissions:
131125
contents: read
@@ -175,7 +169,6 @@ jobs:
175169

176170
Build-Packages:
177171
name: Build Package Check
178-
needs: [ Documentation, Lint, Type-Check, Security, Format ]
179172
runs-on: "(( os_version ))"
180173
permissions:
181174
contents: read
@@ -194,7 +187,6 @@ jobs:
194187

195188
Tests:
196189
name: Unit-Tests (Python-${{ matrix.python-versions }})
197-
needs: [ Build-Packages ]
198190
runs-on: "(( os_version ))"
199191
permissions:
200192
contents: read

exasol/toolbox/templates/github/workflows/merge-gate.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
contents: read
1313

1414
run-slow-tests:
15-
name: Run Slow Tests
15+
name: Run Slow Tests?
1616
runs-on: "(( os_version ))"
1717
permissions:
1818
contents: read

exasol/toolbox/version.py

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)